Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refocused2D.optimal_tau1 accepts only one argument but two arguments are given in calc_deer_settings() #66

Closed
ehuang94 opened this issue Sep 24, 2024 · 1 comment · Fixed by #77
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ehuang94
Copy link

There is an issue when calling calc_deer_settings() to optimize tau 1 for the 4pDEER experiment.

This is a piece of the code in calc_deer_settings():

if tau2 < 2.5:
tau1,tau2 = Refocused2D.optimal_tau1(type='4pDEER',tau2=2.5)

However, the optimal_tau1 only accepts one argument and returns one value:

def optimal_tau1(self,tau2=None,):
...
return self.tau1

@HKaras HKaras self-assigned this Oct 1, 2024
@HKaras HKaras added the bug Something isn't working label Oct 1, 2024
@HKaras HKaras added this to the Version 1.0 milestone Oct 1, 2024
@HKaras HKaras linked a pull request Oct 2, 2024 that will close this issue
@HKaras
Copy link
Member

HKaras commented Oct 2, 2024

A hot fix has now been merged. This function will soon be rewritten.

@HKaras HKaras closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants