Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background change doesn't always happen #4

Open
lukors opened this issue Dec 14, 2021 · 6 comments
Open

Background change doesn't always happen #4

lukors opened this issue Dec 14, 2021 · 6 comments
Labels

Comments

@lukors
Copy link
Contributor

lukors commented Dec 14, 2021

If the style is changed by the schedule it doesn't always trigger the background change.

See this video to see what happens:

Peek.2021-12-14.20-40.mp4

Unfortunately, the app does not generate any log messages.

@JeysonFlores
Copy link
Owner

Mmm, Thanks for test it! I'll be researching a little bit about how does the scheduler work. Depending on how it works it may or may not be misbehavior of the app.

@JeysonFlores
Copy link
Owner

I have good and bad news

@JeysonFlores
Copy link
Owner

JeysonFlores commented Dec 16, 2021

SwitcherBug.4.mp4

Tip: fondo.png (amogus wallpaper) - b.jpg (pink wallpaper)
If you see from the 0:14 the log says that the pink wallpaper was set, but the amogus wallpaper was still there. Also if you see at the 0:36 it looks how the pink wallpaper was set by half a second and then the amogus wallpaper was set again.....
I think this is due to the contractor. If you see the logs whenever that bug appears, the log says the right wallpaper was set. I looked at the code of the Desktop Plug and it seems it uses other method for changing wallpapers (after all it's installed in a system-level, so the fact that this app must be packaged into flatpak means that I cannot do certain things.

@JeysonFlores
Copy link
Owner

JeysonFlores commented Dec 16, 2021

Ok, after debugging the wallpaper setting thing, it seems the code I wrote works fine. The console throws the message about the signal being triggered, the correct mode changed, it also has no errors on finding the wallpaper nor setting it up. I think I'll delegate this error to the contractor provided by the elementary team to interact with the wallpaper set of the desktop.

@ChildishGiant
Copy link

Screenshot from 2021-12-21 10 37 46
I didn't have run on startup selected but launching switcher didn't fix the wallpaper. Maybe this can help reproduce?

@JeysonFlores
Copy link
Owner

Well there are good and bad news about this issue.
The good news: Probably this issue will be fixed
The bad news: It might take a while.

In the submission request Danielle told me that using the contractor to change wallpapers is OK, but there's available a Portal to change wallpapers. I'm still studying about D-Bus, but I hope soon I can start adapting the codebase to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants