Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proxy colonies M1] feat: handle reenabling of a proxy colony #3457

Open
6 tasks
bassgeta opened this issue Oct 24, 2024 · 0 comments
Open
6 tasks

[Proxy colonies M1] feat: handle reenabling of a proxy colony #3457

bassgeta opened this issue Oct 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@bassgeta
Copy link
Contributor

Specification

Story

As a user moderating a colony, I want to "add" a new proxy colony which has been previously removed.

Description

Since we don't remove proxy colonies, but we just disable them in the database, we need to create a new transaction for this which isn't going to call the createProxyColony contract, but probably an editColonyByDelta contract to reenable that proxy colony.
TODO check if it's going to be a problem creating actions of the same type but with different underlying contracts, shouldn't be an issue but you never know

Implementation

This issue is complete when...

  • Reenabling a proxy colony works
  • Reenabling via voting reputation works
  • Reenabling via multisig works

Suggestions (optional)

  • Example: It's probably a good idea to keep the transaction state separate from other async actions that relate to them; i.e. either adding an extra transaction status, or keeping the transaction as PENDING while other async activity finishes would probably lead to some confusion and unintended side effects. Perhaps component state would be a more suitable starting point.

Subtasks (optional)

  • Create a prop (e.g. with component state) which indicates either a transaction is pending, or async activity is in progress related to that transaction, in the context of the wizard
  • Pass down a prop to the TransactionStatus component
  • Adjust the TransactionStatus component such that it shows the indicator with the given prop
@bassgeta bassgeta added the enhancement New feature or request label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant