Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload save and restore to fix a serialization issue #59

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Mar 3, 2024

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.00%. Comparing base (b12c0bc) to head (4db6d59).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #59      +/-   ##
==========================================
+ Coverage   96.93%   97.00%   +0.06%     
==========================================
  Files           7        7              
  Lines         196      200       +4     
==========================================
+ Hits          190      194       +4     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom requested a review from OkonSamuel March 4, 2024 00:03
@paulotrefosco
Copy link

Hello @ablaom ,
Sorry for taking so long to answer, I had to make sure the problem wasn't me. I made some tests and seems to be working properly now (saving and restoring Tuned XGBoost models).
Thanks a lot! Best regards

@ablaom ablaom merged commit 39f58e4 into dev Mar 7, 2024
4 checks passed
@ablaom ablaom mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants