Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformize fields for GLM models ? #277

Open
ghost opened this issue Jul 14, 2020 · 2 comments
Open

Uniformize fields for GLM models ? #277

ghost opened this issue Jul 14, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 14, 2020

Fitted LinearBinaryClassifier() and LinearRegressor() have different field names for the coefficients: coef and coefs.

Are these field names generated within MLJModels? In which case we could adjust.
@ablaom
Copy link
Member

ablaom commented Jul 16, 2020

Thanks for reporting.

Are you referring to the field of fitted_params? As far as I can tell, this is generated for all model simultaneously (see below) so I'm not sure how this is happening. Could you please show some output to demonstrate what you mean?

https://github.com/alan-turing-institute/MLJModels.jl/blob/edd140b590fe87c0b981572dfb76dbbfa00e8be6/src/GLM.jl#L141

@OkonSamuel
Copy link
Member

@gd1989 could you clarify please??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ablaom @OkonSamuel