Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issues with trying to morph box() #372

Open
Sov-trotter opened this issue Jul 24, 2021 · 3 comments
Open

[BUG] Issues with trying to morph box() #372

Sov-trotter opened this issue Jul 24, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@Sov-trotter
Copy link
Member

Sov-trotter commented Jul 24, 2021

Putting it here before it skips out of my mind. (WIll add more details later.)

Trying to morph to/from a box() doesn't quite work.
abox(args...; do_action=:stroke) = box(O, 50, 50, do_action)
Somehow box() doesn't return a path on the canvas.
So internally,

.....
newpath()
box(....)
closepath()
getpath()
....

returns an empty vector of points.

rect() shows similar behaviour, but something like abox(args...; do_action=:stroke) = rect(0,0, 100, 100) works. I suppose the issue lies in the box() function in Luxor https://github.com/JuliaGraphics/Luxor.jl/blob/master/src/shapes.jl.

Once we figure out what the issue is, I think it would be reasonable to create an issue in Luxor.

@Sov-trotter Sov-trotter added the bug Something isn't working label Jul 24, 2021
@Wikunia
Copy link
Member

Wikunia commented Aug 5, 2021

Seems like we call it with do_action = :none and maybe we should call it with do_action = :path ?

@Sov-trotter
Copy link
Member Author

Did that work for you? IIRC it didn't work out for me

@Wikunia
Copy link
Member

Wikunia commented Aug 5, 2021

I didn't try it. Was just an idea. Currently https://github.com/JuliaGraphics/Luxor.jl/blob/master/src/shapes.jl#L85 isn't called because our action is :none right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants