Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Format check is a bit distracting #378

Open
Sov-trotter opened this issue Jul 30, 2021 · 2 comments
Open

[BUG] Format check is a bit distracting #378

Sov-trotter opened this issue Jul 30, 2021 · 2 comments
Labels
bug Something isn't working hacktoberfest Issue for those participating in Hacktoberfest at any skill level

Comments

@Sov-trotter
Copy link
Member

So there are times when I forget to run the formatter and push my commits which results in an extra "format" commit this is also not a good thing to run the CI resources on a format commit.

Is it possible to have it check formatting and automatically format if false??

@Sov-trotter Sov-trotter added the bug Something isn't working label Jul 30, 2021
@Wikunia
Copy link
Member

Wikunia commented Jul 30, 2021

Unfortunately it wasn't that easy last time. I also find it quite annoying from time to time. What we could do is to ignore it until the very end and format it once directly before we merge. I think @TheCedarPrince has a way to format it on saving the file.

@TheCedarPrince
Copy link
Member

So, to comment on this, I did once upon a time have a saving mechanism (Ole did too if I recall correctly) that would autoformat my scripts, but it also introduced unnecessary friction into my workflow. I agree with Ole - I think the best way around this is to format at the end, but I'd rather still have the format check in place as it does remind us to format at the end of the PR process.

@TheCedarPrince TheCedarPrince added the hacktoberfest Issue for those participating in Hacktoberfest at any skill level label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Issue for those participating in Hacktoberfest at any skill level
Projects
None yet
Development

No branches or pull requests

3 participants