Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary double call to counts for association(::JointProbabilities{<:MIShannon}, x, y) #386

Open
kahaaga opened this issue Aug 2, 2024 · 0 comments
Open

Unnecessary double call to counts for association(::JointProbabilities{<:MIShannon}, x, y) #386

kahaaga opened this issue Aug 2, 2024 · 0 comments
Labels
good first issue Good for newcomers performance

Comments

@kahaaga
Copy link
Member

kahaaga commented Aug 2, 2024

In the file methods/information/definitions/mutual_informations/MIShannon.jl:

The cts = counts(est.discretization, x, y) line is completely unnecessary. The counts are automatically computed when calling probabilities on the line below. This extra line essentially doubles computation time.
@kahaaga kahaaga added performance good first issue Good for newcomers labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kahaaga