Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode plot for compositions without UnicodePlots.jl #30

Open
juliohm opened this issue Sep 14, 2022 · 3 comments
Open

Unicode plot for compositions without UnicodePlots.jl #30

juliohm opened this issue Sep 14, 2022 · 3 comments

Comments

@juliohm
Copy link
Member

juliohm commented Sep 14, 2022

The UnicodePlots.jl has become a heavy dependency as explained here:

JuliaPlots/UnicodePlots.jl#291

Maybe we should consider copying the code for bar plots to CoDa.jl (with appropriate credits) and drop UnicodePlots.jl from our list of dependencies. I didn't have time to investigate the code yet, but it is good way forward to make this package more slim and self-contained in the future.

@juliohm
Copy link
Member Author

juliohm commented Sep 29, 2022

There are too many types and hacks in UnicodePlots.jl that make it difficult to isolate the plot recipe. Therefore, I removed the dependency and added a note to the README in case someone wants to reproduce the bar plot.

@juliohm juliohm closed this as completed Sep 29, 2022
@juliohm
Copy link
Member Author

juliohm commented Jan 25, 2023

I will reopen the issue in case someone is willing to help with a new unicode plot that is self-contained without the UnicodePlots.jl dependency.

@juliohm juliohm reopened this Jan 25, 2023
@juliohm juliohm changed the title Copy code from UnicodePlots.jl Implement unicode plot for compositions without UnicodePlots.jl Jan 25, 2023
@juliohm juliohm changed the title Implement unicode plot for compositions without UnicodePlots.jl Unicode plot for compositions without UnicodePlots.jl Jan 25, 2023
@juliohm
Copy link
Member Author

juliohm commented Jul 24, 2023

Alternatively, we can now rely on package extensions in Julia v1.9 to load the code whenever the UnicodePlots.jl package is loaded in the same session. I don't know if it addresses the issue properly, but at least we get a nice output while a lighter approach is not proposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant