Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MetricManifold to ManifoldsBase.jl and extend its interface #140

Open
kellertuer opened this issue Dec 12, 2022 · 2 comments
Open

Move MetricManifold to ManifoldsBase.jl and extend its interface #140

kellertuer opened this issue Dec 12, 2022 · 2 comments

Comments

@kellertuer
Copy link
Member

I think the metric manifold decorator is mature enough to be moved here,
maybe even with a few metric types (maybe also just EuclideanMetric).

We could use this also to introduce the function

get_metric(::AbstracManifold)

which would return just the .metric field for a MetricManifold and otherwise the default metric (stored in a trait, so maybe a little tricky to obtain, but surely doable).

@mateuszbaran
Copy link
Member

Yes, I think basic definitions of MetricManifold could be moved here.

get_metric(::AbstracManifold)

We already have the metric function which does that for MetricManifold. I think we could just extend it to other manifolds.

(stored in a trait, so maybe a little tricky to obtain, but surely doable).

That should be fine if metric/get_metric becomes a trait function.

@kellertuer
Copy link
Member Author

Ah, sure, I forgot about that. Then let's extend that function, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants