Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard Yggdrasil push is broken #1294

Open
Keno opened this issue Sep 20, 2023 · 4 comments
Open

Wizard Yggdrasil push is broken #1294

Keno opened this issue Sep 20, 2023 · 4 comments

Comments

@Keno
Copy link
Contributor

Keno commented Sep 20, 2023

[ Info: Checking temporary Yggdrasil out to /tmp/jl_NYh1yK
[ Info: Generating C/charon/build_tarballs.jl
[ Info: Committing and pushing to Keno/Yggdrasil#wizard/charon-v2.2.0_c1a2a2b9...
ERROR: GitError(Code:EAUTH, Class:Callback, The explicitly provided credential is incompatible with the requested authentication methods.)
@Keno
Copy link
Contributor Author

Keno commented Sep 20, 2023

This might be because I have a global
url.ssh://[email protected]/.insteadof=https://github.com/. If so, we should either overwrite this (since we're explicitly passing credentials) or print a better error.

@jd-foster
Copy link

Possibly related to the 40 character check raised in #1281 that is out of step with the newer 93 character "Fine-grained tokens":

if (!isassigned(_github_auth) || !allow_anonymous && isa(_github_auth[], GitHub.AnonymousAuth)) && length(get(ENV, "GITHUB_TOKEN", "")) == 40

@jd-foster
Copy link

jd-foster commented Oct 26, 2023

Ok, 93 char vs 40 char check is a thing that should probably be removed, but this issue seems to come from this line

creds = LibGit2.UserPasswordCredential(deepcopy(username), deepcopy(password))

which can be incompatible with a configuration using ssh://[email protected]/, and would need to instead be

creds = LibGit2.SSHCredential(deepcopy(username), deepcopy(password)) 

@tpgillam
Copy link

tpgillam commented Jan 9, 2024

Just ran into the same thing while prototyping a new jll. I also have the same https -> ssh insteadOf override in my .gitconfig.

I can temporarily comment out the line from my .gitconfig, which ok for my current purpose... did you find a more permanent workaround?

Also I'm wondering whether it's possible to conditionally use the LibGit2.SSHCredential when it would be required. But maybe this is hard, because point of calling with_gitcred we don't necessarily know whether url might be translated from https -> ssh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants