Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI with two Julia threads active #340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

oschulz
Copy link
Member

@oschulz oschulz commented May 21, 2023

No description provided.

@oschulz oschulz mentioned this pull request May 21, 2023
@fhagemann
Copy link
Collaborator

What happens if we set this to 8 threads? ^^
And any idea why we are getting an OutOfMemoryError on x86?

@oschulz
Copy link
Member Author

oschulz commented May 21, 2023

What happens if we set this to 8 threads?

Well, the default GitHub Actions runner only has two virtual CPUs, so that should work but provide no speed-up.

And any idea why we are getting an OutOfMemoryError on x86

Nope ...

@oschulz
Copy link
Member Author

oschulz commented May 21, 2023

I'll re-run all CI jobs to time them again.

@fhagemann
Copy link
Collaborator

Am I seeing it right that the ubuntu x64 tests on Julia 1 take almost 4 hours (?)

@oschulz
Copy link
Member Author

oschulz commented May 25, 2023

Am I seeing it right that the ubuntu x64 tests on Julia 1 take almost 4 hours (?)

Yes, and it seems to be reproducible, and I don't understand why. Before (this PR) it was about 1.5h. But the tests on the other platforms, that also used to take around 1.5 h, do run in about 50 minutes now, which makes sense.

@oschulz
Copy link
Member Author

oschulz commented May 28, 2023

I've added test timers to this PR (should be useful in general), let's see where all the time is spent.

@oschulz
Copy link
Member Author

oschulz commented May 29, 2023

Tests on Julia v1.9 keep failing with out-of-memory, not sure why (and why only when using multithreading).

Docs failures should be fixed by #341.

@fhagemann
Copy link
Collaborator

ubuntu x64 is still significantly slower than the rest..

@oschulz
Copy link
Member Author

oschulz commented Jan 27, 2024

ubuntu x64 is still significantly slower than the rest..

Yes, massively - but I haven't the faintest intuition on why, it looks really strange.

@oschulz
Copy link
Member Author

oschulz commented Jan 27, 2024

How long does it run locally, on two core, x86-64, in comparison? Maybe the GitHub x86-64 runners are just in higher demand and more heavily oversubscribed?

@fhagemann
Copy link
Collaborator

Let's see whether something has changed here ever since..

@fhagemann fhagemann added the help wanted Extra attention is needed label Sep 22, 2024
@fhagemann
Copy link
Collaborator

@oschulz looks like the tests all speed up except for the one also testing the code coverage. Any idea why?

@fhagemann
Copy link
Collaborator

I rebased this PR onto the current main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants