-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI with two Julia threads active #340
base: main
Are you sure you want to change the base?
Conversation
What happens if we set this to 8 threads? ^^ |
Well, the default GitHub Actions runner only has two virtual CPUs, so that should work but provide no speed-up.
Nope ... |
I'll re-run all CI jobs to time them again. |
Am I seeing it right that the ubuntu x64 tests on Julia 1 take almost 4 hours (?) |
Yes, and it seems to be reproducible, and I don't understand why. Before (this PR) it was about 1.5h. But the tests on the other platforms, that also used to take around 1.5 h, do run in about 50 minutes now, which makes sense. |
I've added test timers to this PR (should be useful in general), let's see where all the time is spent. |
a66b7a2
to
fc11db5
Compare
Tests on Julia v1.9 keep failing with out-of-memory, not sure why (and why only when using multithreading). Docs failures should be fixed by #341. |
0031a2d
to
9980c4c
Compare
ubuntu x64 is still significantly slower than the rest.. |
Yes, massively - but I haven't the faintest intuition on why, it looks really strange. |
How long does it run locally, on two core, x86-64, in comparison? Maybe the GitHub x86-64 runners are just in higher demand and more heavily oversubscribed? |
81e96dd
to
9980c4c
Compare
Let's see whether something has changed here ever since.. |
@oschulz looks like the tests all speed up except for the one also testing the code coverage. Any idea why? |
9980c4c
to
9f79599
Compare
I rebased this PR onto the current |
No description provided.