Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make comments non-blocking by default #117892

Open
goerz opened this issue Oct 23, 2024 · 2 comments
Open

Make comments non-blocking by default #117892

goerz opened this issue Oct 23, 2024 · 2 comments

Comments

@goerz
Copy link
Member

goerz commented Oct 23, 2024

I appreciate the community review of the General registry, in that anyone can leave a blocking comment on a new registration. However, the more "community review" actually happens, and thus, the more comments there are for registration PRs, the more it is a problem that comments are blocking by default.

I would propose that we change from comments being blocking unless they contain [noblock] to comments being non-blocking unless they contain [block]. I have no problem personally navigating [noblock], but I have to spend a very significant percentage of my registry review time just typing messages to people reminding them to add [noblock]. Latest example:

#117882

It's very easy to forget about [noblock] once a discussion gets going. My experience is also that 90% of comments are intended to be non-blocking. Those that are intended to block are usually just the first comment, and usually by a small group of people (myself included) that check new submissions for issues such as misleading names or insufficient documentation. I think that group of people will easily adapt to [block].

P.S.: I'm not sure if this issue belongs here, or, e.g., in https://github.com/JuliaRegistries/RegistryCI.jl. Please feel free to transfer if appropriate.

@ericphanson
Copy link
Member

I think that makes sense. One thing that might make this easier is a new label: JuliaRegistries/RegistryCI.jl#573

However that can work in addition to changing the default.

@DilumAluthge
Copy link
Member

For now, let's try keeping the default as blocking, and see if JuliaRegistries/RegistryCI.jl#573 makes things easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants