Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for features in DeviceDescriptor #23

Open
JeffreyPalmer opened this issue May 4, 2024 · 4 comments
Open

No support for features in DeviceDescriptor #23

JeffreyPalmer opened this issue May 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@JeffreyPalmer
Copy link
Contributor

Hi!

I was attempting to use some of the WebGPU features (specifically WGPUFeatureName_Float32Filterable) when I noticed that there is currently no support for any additional feature requests in the device implementation. Is that something that you have added elsewhere, or should I put together a PR to add support for them?

Thanks!

@arhik
Copy link
Member

arhik commented May 4, 2024

@JeffreyPalmer Currently we lack basic api to query features in adapter.jl file, choose device, and request feature in device.jl.

Choosing device is a separate issue here JuliaWGPU/WGPUgfx.jl#29. (Should have been raised in WGPUCore)

Our approach so far has been need-basis. We are filling API as we need them. We would definitely want to have this and I will add that to the feature tracking list here https://github.com/orgs/JuliaWGPU/projects/1. If you have bandwidth to work on it PR would be great.

@arhik arhik added the enhancement New feature or request label May 4, 2024
@JeffreyPalmer
Copy link
Contributor Author

Thanks for the feedback. I'm relatively new to Julia FFI stuff, but I think I can probably solve my immediate need and go from there. I'll take a look. 🙏

@JeffreyPalmer
Copy link
Contributor Author

Sorry I ghosted this conversation. I ended up using OpenGL for my immediate needs, due to the stability of the package, but I'm still very interested in this work as it moves forward. 🙏

Please feel free to close this issue if you'd like.

@arhik
Copy link
Member

arhik commented Oct 2, 2024

There was 3-5 months gap in our contributions to JuliaWGPU (I was busy with my startup). Since we are lagging with upstream WGPU version, We will start working on WGPUNative updates soon anyways. It will then be ripe time to address this issue too. Until then lets keep it open. Hopefully it can be addressed in 1-2 weeks. Apologies for keeping you wait on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants