Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux binares are broken #1844

Closed
ghost opened this issue Jun 12, 2020 · 4 comments
Closed

Linux binares are broken #1844

ghost opened this issue Jun 12, 2020 · 4 comments
Labels
🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug. ❌ Won't fix Issues marked with this label are not considered and they won't receive any development action.

Comments

@ghost
Copy link

ghost commented Jun 12, 2020

Bug report

Description

After switching to PublishSingleFile with last two releases, ArchiSteamFarm linux binares don't run anymore

Expected behavior

They should run

Current behavior

$ ./ArchiSteamFarm
Failure processing application bundle; possible file corruption.
I/O failure reading contents of the bundle.
A fatal error was encountered. Could not extract contents of the bundle

Possible solution

Build bots should not strip binaries. See e.g. dotnet/runtime#37334

$ file ArchiSteamFarm
ArchiSteamFarm: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=012a114db617d95c3c01834f9a677f656db66d38, stripped

@ghost ghost added 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 12, 2020
@JustArchi
Copy link
Member

JustArchi commented Jun 12, 2020

Works fine for me.

image

With what environment are you reproducing this issue? I don't believe this is ASF issue. Docker containers using single file publish binaries also work fine with ASF, so I don't believe this is global issue.

The stripping you've mentioned has nothing to do with this issue, .NET Core SDK is in charge of generating the binaries.

@JustArchi JustArchi added ⁉️ Can't reproduce Issues marked with this label can't be reproduced by the developer, more info needed. 🤔 Requires more info Issues marked with this label are incomplete - please provide requested details for moving forward. labels Jun 12, 2020
@Rudokhvist
Copy link
Member

Works for me (in VirtualBox with Ubuntu)
изображение

@Abrynos
Copy link
Member

Abrynos commented Jun 12, 2020

Works for me as well. arm version

2020-06-12 04:00:22|ArchiSteamFarm-305|INFO|ASF|InitASF() ArchiSteamFarm V4.2.2.1 (linux-arm/db54572c-891f-4965-9ce5-2e48ab7b9992 | Linux 4.19.66-v7+ #1253 SMP Thu Aug 15 11:49:46 BST 2019)
2020-06-12 04:00:33|ArchiSteamFarm-305|INFO|ASF|UpdateAndRestart() ASF will automatically check for new versions every 6 hours.
2020-06-12 04:00:33|ArchiSteamFarm-305|INFO|ASF|Update() Checking for new version...

and x64 version

2020-06-12 11:26:40|ArchiSteamFarm-65537|INFO|ASF|InitASF() ArchiSteamFarm V4.2.2.1 (linux-x64/3a779045-28f5-4c22-8192-d48f4420690c | Linux 5.6.0-2-amd64 #1 SMP Debian 5.6.14-1 (2020-05-23))
2020-06-12 11:26:40|ArchiSteamFarm-65537|INFO|ASF|InitGlobalDatabaseAndServices() It looks like it's your first launch of the program, welcome!

and docker

docker container run --rm -v ./config:/app/config -v ./log.txt:/app/log.txt justarchi/archisteamfarm:released
Unable to find image 'justarchi/archisteamfarm:released' locally
released: Pulling from justarchi/archisteamfarm
afb6ec6fdc1c: Already exists
5690d8bb6f50: Already exists
63fdd22196ea: Already exists
e0a4da67bf1b: Already exists
5e71584d3dd9: Already exists
b5686ed788e9: Pull complete
c12346c5c51b: Pull complete
Digest: sha256:45e4ff8287698c8d62ba438e50fcf938cd7ea56404cb9b7446d650ef3eb79e80
Status: Downloaded newer image for justarchi/archisteamfarm:released
  It was not possible to find any installed .NET Core SDKs
  Did you mean to run .NET Core SDK commands? Install a .NET Core SDK from:
      https://aka.ms/dotnet-download

Host (useful for support):
  Version: 3.1.4
  Commit:  0c2e69caa6

.NET Core SDKs installed:
  No SDKs were found.

.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.1.4 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.1.4 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download
2020-06-12 09:32:03|dotnet-11|INFO|ASF|InitASF() ArchiSteamFarm V4.2.2.1 (docker/a9c239a3-3f9c-41b3-baf6-cba36ded470b | Linux 4.19.76-linuxkit #1 SMP Tue May 26 11:42:35 UTC 2020)
2020-06-12 09:32:03|dotnet-11|INFO|ASF|InitGlobalDatabaseAndServices() It looks like it's your first launch of the program, welcome!
2020-06-12 09:32:13|dotnet-11|WARN|ASF|InitGlobalDatabaseAndServices() Please review our privacy policy section on the wiki if you're concerned about what ASF is in fact doing!

@JustArchi
Copy link
Member

That's enough of data for me to claim that this issue is in fact a technical issue and not a bug. Thanks.

@JustArchi JustArchi added 🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug. ❌ Won't fix Issues marked with this label are not considered and they won't receive any development action. and removed 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ⁉️ Can't reproduce Issues marked with this label can't be reproduced by the developer, more info needed. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. 🤔 Requires more info Issues marked with this label are incomplete - please provide requested details for moving forward. labels Jun 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug. ❌ Won't fix Issues marked with this label are not considered and they won't receive any development action.
Projects
None yet
Development

No branches or pull requests

3 participants