Fixes related to issue #977 #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #977 by making suggested change to connect to QCoreApplication
CMAKE_PREFIX_PATHs that contained both Qt 5 and 6 would trigger lines specific to both versions of the framework instead of only running lines specific to the version being used for compilation Solves #997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure to build with DGAMMARAY_BUILD_UI=OFF in absence of QWidgets.
Fixes #977 by making suggested change to connect to QCoreApplication.
CMAKE_PREFIX_PATHs that contained both Qt 5 and 6 would trigger
lines specific to both versions of the framework instead of only
running lines specific to the version being used for compilation.
Added ${} to all instances where CMAKE_PREFIX_PATH is compared for
correct results.