-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write the catalog files at the end of the process #1250
Comments
The first batch for @kaoto/camel-catalog tests fix: KaotoIO#1250
Hi @shivamG640, I have a proposal for the catalog-generator test: Extract each of these methods to individual classes, under a dedicated package By doing this, we can assert over the output of each class while also being able to mock them when needed to test the main class. We should be able to postpone writing the files as a much as possible, up to the generate command. |
@mhempleman As you already noticed, we're adding tests for the catalog generator, and as part of this effort, we're thinking of reorganizing a few classes to make them more testable. We're collecting proposals for this issue, and since you're contributing to the catalog generator, we wanted to give you a heads-up. This won't affect I don't think it will affect #1311, since whatever is decided, it should be implemented on a step-by-step basis. That being said, if you have a proposal or feedback about what changes would be nice to implement to make the catalog generator more robust and testable, please let us know so we can incorporate your feedback. |
At this time, we're adding tests for the `ConfigBean` class and the `GenerateCommandTest` class. fix: KaotoIO#1250
At this time, we're adding tests for the `ConfigBean` class and the `GenerateCommandTest` class. fix: KaotoIO#1250
At this time, we're adding tests for the `ConfigBean` class and the `GenerateCommandTest` class. fix: KaotoIO#1250
Since the tests were migrated to the new `catalog-generator` package, is safe to remove this package. fix: KaotoIO#1250
Please describe the task that needs to be done
Currently, the catalog generation workflow looks like the following:
index.json
fileThe idea is to generate everything in memory and as the last step, write everything to file. This to be able to run assertions against the output more easily.
Todo
Main
class andGenerateCommandOptions
class (chore(test): Add tests for @kaoto/camel-catalog #1312)GenerateCommand
class andConfigBean
class (chore(catalog-generator): Add tests for the Catalog generator #1519)io.kaoto.camelcatalog
package (camel-catalog
) (chore(catalog-generator): Bring previous tests #1530)camel-catalog
package (chore(camel-catalog-plugin): Remove camel-catalog-plugin package #1531)The text was updated successfully, but these errors were encountered: