Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap pagination causes issues with text selection (epub) (android) #2694

Open
YodaDaCoda opened this issue Feb 6, 2024 · 2 comments · May be fixed by #2754
Open

Tap pagination causes issues with text selection (epub) (android) #2694

YodaDaCoda opened this issue Feb 6, 2024 · 2 comments · May be fixed by #2754
Labels
needs-triage Needs to be triaged by a developer and assigned a release

Comments

@YodaDaCoda
Copy link
Contributor

What happened?

With tap pagination enabled, selecting text at the edges of a page causes the page to jump to the beginning of the chapter, and what seems like the entire chapter is selcted. Selecting text somewhere in the middle of the page works fine. This issue mostly arises when I attempt to select a word so I can use the context-menu dictionary lookup on my ereader.

What did you expect?

I expect to be able to select text that I can see on the page, without tap pagination affecting this.

Kavita Version Number - Don't see your version number listed? Then your install is out of date. Please update and see if your issue still persists.

0.7.13 - Stable

What operating system is Kavita being hosted from?

Docker (LSIO Container)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

None

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Firefox

If the issue is being seen on Mobile, what OS are you running where you see the issue?

Android

If the issue is being seen on the UI, what browsers are you seeing the problem on?

Firefox

Relevant log output

N/A

Additional Notes

I suspect this could be fixed in css by setting the left/right floating sections to user-select: none; MDN

@YodaDaCoda YodaDaCoda added the needs-triage Needs to be triaged by a developer and assigned a release label Feb 6, 2024
@YodaDaCoda
Copy link
Contributor Author

Did some debugging, user-select: none; did not help. Looks like making the tap pagination floating bars the same width as the margin setting might be the way to go. This would have issues with margin setting of 0%.

@ShivamAmin
Copy link
Contributor

ShivamAmin commented Apr 13, 2024

Commit 2fd756f1f4ed56950ffc3ad40545b08e4ee002f1 in my pr #2754 addresses this issue. When you have Tap to Paginate enabled, my pr makes it so that if you bring up the top menu, it will temporarily disable (prevent the render of) the prev/next buttons on the page. Then you are free to select or click any links that were previously under the buttons. If you want to re-enable tap to paginate, you can tap the center of the screen (or click) to hide the menu and the invisible pagination buttons will be back. This also still allows you to paginate when the menu is open using the menu pagination buttons, and also your keyboard arrow keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs to be triaged by a developer and assigned a release
Projects
Development

Successfully merging a pull request may close this issue.

2 participants