From 5a763b6c0f4a2d2459bcd077543129af5c37f941 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Krch?= Date: Thu, 19 Sep 2024 05:47:07 +0200 Subject: [PATCH] #245 partial refactor - url manager is used instead of low level api --- .../Handlers/MigratePagesCommandHandler.cs | 117 +++++++----------- KVA/Migration.Toolkit.Source/ModelFacade.cs | 2 +- .../Services/Ipc/Model.cs | 2 +- 3 files changed, 45 insertions(+), 76 deletions(-) diff --git a/KVA/Migration.Toolkit.Source/Handlers/MigratePagesCommandHandler.cs b/KVA/Migration.Toolkit.Source/Handlers/MigratePagesCommandHandler.cs index 87bd50b0..fb60c5d1 100644 --- a/KVA/Migration.Toolkit.Source/Handlers/MigratePagesCommandHandler.cs +++ b/KVA/Migration.Toolkit.Source/Handlers/MigratePagesCommandHandler.cs @@ -44,7 +44,7 @@ public class MigratePagesCommandHandler( ModelFacade modelFacade, DeferredPathService deferredPathService, SpoiledGuidContext spoiledGuidContext, - SourceInstanceContext sourceInstanceContext + SourceInstanceContext sourceInstanceContext ) : IRequestHandler { @@ -61,8 +61,6 @@ public async Task Handle(MigratePagesCommand request, Cancellatio var cultureCodeToLanguageGuid = modelFacade.SelectAll() .ToDictionary(c => c.CultureCode, c => c.CultureGUID, StringComparer.InvariantCultureIgnoreCase); - var allTargetLanguages = ContentLanguageInfoProvider.ProviderObject.Get().ToList(); - var sites = modelFacade.SelectAll(); foreach (var ksSite in sites) { @@ -93,8 +91,8 @@ public async Task Handle(MigratePagesCommand request, Cancellatio .SelectWhere("DocumentNodeID = @nodeId", new SqlParameter("nodeId", ksNode.NodeID)) .ToList(); - bool isLinkedNode = nodeLinkedNode != null; - if (isLinkedNode) + bool wasLinkedNode = nodeLinkedNode != null; + if (wasLinkedNode) { if (nodeLinkedNode?.NodeSiteID != ksNode.NodeSiteID) { @@ -248,7 +246,8 @@ public async Task Handle(MigratePagesCommand request, Cancellatio if (webPageItemInfo != null && targetClass is { ClassWebPageHasUrl: true }) { - var existingDocumentLanguages = new HashSet(); + await GenerateDefaultPageUrlPath(ksNode, webPageItemInfo, wasLinkedNode); + foreach (var migratedDocument in migratedDocuments) { var languageGuid = cultureCodeToLanguageGuid[migratedDocument.DocumentCulture]; @@ -259,22 +258,7 @@ await MigratePageUrlPaths(ksSite.SiteGUID, migratedDocument, ksNode, migratedDocument.DocumentCulture, - isLinkedNode, webPageItemInfo); - - existingDocumentLanguages.Add(languageGuid); - } - - var channelCulturesWithoutPage = allTargetLanguages.Where(x => existingDocumentLanguages.All(y => y != x.ContentLanguageGUID)); - - foreach (var culture in channelCulturesWithoutPage) - { - await MigratePageUrlPaths(ksSite.SiteGUID, - culture.ContentLanguageGUID, - commonDataInfos, - null, - ksNode, - culture.ContentLanguageName, - isLinkedNode, webPageItemInfo); + wasLinkedNode, webPageItemInfo); } MigrateFormerUrls(ksNode, webPageItemInfo); @@ -305,7 +289,7 @@ await MigratePageUrlPaths(ksSite.SiteGUID, } } - await ExecDeferredPageBuilderPatch(); + await ExecDeferredPageBuilderPatch(); return new GenericCommandResult(); } @@ -348,29 +332,25 @@ public enum PageRoutingModeEnum // copy of enum from KX13 dll BasedOnContentTree = 1, } - private readonly Dictionary cmsClassCache = new(); + private readonly Dictionary cmsClassCache = []; private ICmsClass GetCmsClass(int classId) { if (cmsClassCache.TryGetValue(classId, out var cmsClass)) { return cmsClass; } - + cmsClass = modelFacade.SelectById(classId); cmsClassCache[classId] = cmsClass ?? throw new InvalidOperationException($"CMS Class with class id {classId} not found => invalid data"); return cmsClass; } - + private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGuid, - List contentItemCommonDataInfos, ICmsDocument? ksDocument, ICmsTree ksTree, string documentCulture, bool isLinkedNode, WebPageItemInfo webPageItemInfo) + List contentItemCommonDataInfos, ICmsDocument? ksDocument, ICmsTree ksTree, string documentCulture, bool wasLinkedNode, WebPageItemInfo webPageItemInfo) { - var existingPaths = WebPageUrlPathInfo.Provider.Get() - .WhereEquals(nameof(WebPageUrlPathInfo.WebPageUrlPathWebPageItemID), webPageItemInfo.WebPageItemID) - .ToList(); - var languageInfo = ContentLanguageInfoProvider.ProviderObject.Get(languageGuid); var webSiteChannel = WebsiteChannelInfoProvider.ProviderObject.Get(webSiteChannelGuid); - + #region Migration of custom routing model if (modelFacade.SelectVersion() is { Major: 13 } && KenticoHelper.GetSettingsKey(modelFacade, ksTree.NodeSiteID, "CMSRoutingMode") is (int)PageRoutingModeEnum.Custom) @@ -403,11 +383,11 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui else { string patchedUrl = pageModel.CultureUrl.TrimStart(['~']).TrimStart(['/']); - + foreach (var contentItemCommonDataInfo in contentItemCommonDataInfos.Where(x => x.ContentItemCommonDataContentLanguageID == languageInfo.ContentLanguageID)) { logger.LogTrace("Page url path common data info: CIID={ContentItemId} CLID={Language} ID={Id} IPC", contentItemCommonDataInfo.ContentItemCommonDataContentItemID, contentItemCommonDataInfo.ContentItemCommonDataContentLanguageID, contentItemCommonDataInfo.ContentItemCommonDataID); - + // decision - if change in url occurs in source instance, it is desirable to overwrite migrated one. var webPageUrlPathGuid = contentItemCommonDataInfo.ContentItemCommonDataVersionStatus == VersionStatus.Draft ? GuidHelper.CreateWebPageUrlPathGuid($"{ksDocument!.DocumentGUID}|{documentCulture}|{ksTree.NodeAliasPath}|DRAFT|{ksTree.NodeID}") @@ -434,7 +414,7 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui } }; - CheckPathAlreadyExists(existingPaths, webPageUrlPath, languageInfo, webSiteChannel); + CheckPathAlreadyExists(webPageUrlPath, languageInfo, webSiteChannel, webPageItemInfo.WebPageItemID); var importResult = await importer.ImportAsync(webPageUrlPath); @@ -446,7 +426,7 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui } #endregion - + if (modelFacade.IsAvailable()) { var ksPaths = modelFacade.SelectWhere("PageUrlPathNodeId = @nodeId AND PageUrlPathCulture = @culture", @@ -454,11 +434,6 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui new SqlParameter("culture", documentCulture) ).ToList(); - if (ksDocument is null) - { - await Service.Resolve().GeneratePageUrlPath(webPageItemInfo, ksTree.NodeAlias, VersionStatus.InitialDraft, CancellationToken.None); - } - if (ksPaths.Count > 0) { foreach (var ksPath in ksPaths) @@ -493,7 +468,7 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui } }; - CheckPathAlreadyExists(existingPaths, webPageUrlPath, languageInfo, webSiteChannel); + CheckPathAlreadyExists(webPageUrlPath, languageInfo, webSiteChannel, webPageItemInfo.WebPageItemID); var importResult = await importer.ImportAsync(webPageUrlPath); @@ -501,29 +476,9 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui } } } - else - { - if (ksDocument is null) - { - await Service.Resolve().GeneratePageUrlPath(webPageItemInfo, ksTree.NodeAlias, VersionStatus.InitialDraft, CancellationToken.None); - } - foreach (var contentItemCommonDataInfo in contentItemCommonDataInfos.Where(x => x.ContentItemCommonDataContentLanguageID == languageInfo.ContentLanguageID)) - { - logger.LogTrace("Page url path common data info: CIID={ContentItemId} CLID={Language} ID={Id} - fallback", - contentItemCommonDataInfo.ContentItemCommonDataContentItemID, contentItemCommonDataInfo.ContentItemCommonDataContentLanguageID, - contentItemCommonDataInfo.ContentItemCommonDataID); - - await Service.Resolve().GeneratePageUrlPath(webPageItemInfo, ksTree.NodeAlias, contentItemCommonDataInfo.ContentItemCommonDataVersionStatus, CancellationToken.None); - } - } } else { - if (ksDocument is null) - { - await Service.Resolve().GeneratePageUrlPath(webPageItemInfo, ksTree.NodeAlias, VersionStatus.InitialDraft, CancellationToken.None); - } - foreach (var contentItemCommonDataInfo in contentItemCommonDataInfos.Where(x => x.ContentItemCommonDataContentLanguageID == languageInfo.ContentLanguageID)) { logger.LogTrace("Page url path common data info: CIID={ContentItemId} CLID={Language} ID={Id}", contentItemCommonDataInfo.ContentItemCommonDataContentItemID, @@ -531,16 +486,12 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui string? urlPath = (ksDocument switch { - CmsDocumentK11 doc => isLinkedNode ? null : doc.DocumentUrlPath, - CmsDocumentK12 doc => isLinkedNode ? null : doc.DocumentUrlPath, + CmsDocumentK11 doc => wasLinkedNode ? null : doc.DocumentUrlPath, + CmsDocumentK12 doc => wasLinkedNode ? null : doc.DocumentUrlPath, _ => null }).NullIf(string.Empty)?.TrimStart('/'); - if (urlPath is null) - { - await Service.Resolve().GeneratePageUrlPath(webPageItemInfo, ksTree.NodeAlias, contentItemCommonDataInfo.ContentItemCommonDataVersionStatus, CancellationToken.None); - } - else + if (urlPath is not null) { var webPageUrlPath = new WebPageUrlPathModel { @@ -560,6 +511,8 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui } }; + CheckPathAlreadyExists(webPageUrlPath, languageInfo, webSiteChannel, webPageItemInfo.WebPageItemID); + var importResult = await importer.ImportAsync(webPageUrlPath); LogImportResult(importResult); @@ -568,16 +521,32 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui } } - private void CheckPathAlreadyExists(List existingPaths, WebPageUrlPathModel webPageUrlPath, + private async Task GenerateDefaultPageUrlPath(ICmsTree ksTree, WebPageItemInfo webPageItemInfo, bool wasLinkedNode) + { + var man = Service.Resolve(); + string alias = wasLinkedNode ? ksTree.NodeAlias : ksTree.NodeAliasPath; + var collisionData = await man.GeneratePageUrlPath(webPageItemInfo, alias, VersionStatus.InitialDraft, CancellationToken.None); + foreach (var data in collisionData) + { + logger.LogError("WebPageUrlPath collision occured {Path}", data.Path); + } + } + + private void CheckPathAlreadyExists(WebPageUrlPathModel webPageUrlPath, ContentLanguageInfo languageInfo, - WebsiteChannelInfo webSiteChannel) + WebsiteChannelInfo webSiteChannel, int webPageItemId) { + Debug.Assert(webPageUrlPath is not { WebPageUrlPathIsLatest: false, WebPageUrlPathIsDraft: true },"webPageUrlPath is not { WebPageUrlPathIsLatest: false, WebPageUrlPathIsDraft: true }"); + + var existingPaths = WebPageUrlPathInfo.Provider.Get() + .WhereEquals(nameof(WebPageUrlPathInfo.WebPageUrlPathWebPageItemID), webPageItemId) + .ToList(); + var ep = existingPaths.FirstOrDefault(ep => - ep.WebPageUrlPath == webPageUrlPath.WebPageUrlPath && ep.WebPageUrlPathContentLanguageID == languageInfo.ContentLanguageID && ep.WebPageUrlPathIsDraft == webPageUrlPath.WebPageUrlPathIsDraft && - ep.WebPageUrlPathIsLatest == webPageUrlPath.WebPageUrlPathIsLatest && - ep.WebPageUrlPathWebsiteChannelID == webSiteChannel.WebsiteChannelID + ep.WebPageUrlPathWebsiteChannelID == webSiteChannel.WebsiteChannelID && + ep.WebPageUrlPathWebPageItemID == webPageItemId ); if (ep != null) diff --git a/KVA/Migration.Toolkit.Source/ModelFacade.cs b/KVA/Migration.Toolkit.Source/ModelFacade.cs index 5a2fe51c..9cb95ca4 100644 --- a/KVA/Migration.Toolkit.Source/ModelFacade.cs +++ b/KVA/Migration.Toolkit.Source/ModelFacade.cs @@ -157,7 +157,7 @@ public SemanticVersion SelectVersion() { return semanticVersion; } - + using var conn = GetConnection(); conn.Open(); diff --git a/Migration.Toolkit.Common/Services/Ipc/Model.cs b/Migration.Toolkit.Common/Services/Ipc/Model.cs index 645c1887..9a695942 100644 --- a/Migration.Toolkit.Common/Services/Ipc/Model.cs +++ b/Migration.Toolkit.Common/Services/Ipc/Model.cs @@ -6,7 +6,7 @@ public class SourceInstanceDiscoveredInfo public Dictionary>? WidgetProperties { get; set; } public Dictionary>? PageTemplateProperties { get; set; } public Dictionary>? SectionProperties { get; set; } - public List PageModels { get; set; } = new(); + public List PageModels { get; set; } = []; public string SiteName { get; set; } }