Fillet UI

[Irev-Dev]

Screenshare.-.2024-06-05.3_47_08.PM.mp4

related to #729 roadmap

public release countdown:

• Group All Fillet Tags Under a Single Fillet Expression for Multiple Selections #4039
• Add Multiple Fillet Selection Support to Command Bar UI #3833
• Add support for opposite and adjacent edge selection for fillets #4082
• Add Support for Fillet with Extrude in the Sketch Pipe #4112
• Selections Refactor #4381
• add support of fillets in revolve (blocked by engine)

chamfers

• Refactor Fillet Function to Support Chamfers #4527
• rename addFillet.ts to addEdgeTreatment.ts #4642
• hook up chamfer ui with ast-mod #4693

todo

• write AST-mod for adding fillet, piped to extrude variable expression #2607
• Fillet UI #2718
• Add unit tests for hasValidFilletSelection #3051
• More of the logic in AST fillet action should be tested #3036
• Bug: Button State Error #3682
• Suppress Expected Errors in getArtifactOfTypes #3722
• Refactor button states
• add edges to Artifact Graph (Fillet UI related) #3675 (clean PR with only the artifact)
• Hide the Fillet command from the command palette #4550
• convert ast fillet from xstate action to async actor and remove eslint disabling comments #4749
• refactor fillet playwright test to the new fixture-based approach #4821
• codemod fails to update kcl source after fillet operation on bodies with existing revolve features #4748
• add support for edge deselection #4760
• Find and purge all actual tags from existing fillets. Update getFilletTag / isTagUsedInFillet or add selection error warning to the ui
• remove isTagUsedInEdgeTreatment
• Add a bodyHelperMap
• Pull out getPathToNodeOfFilletLiteral and write unit test for it
• Selecting a single edge when it exists in a fillet call with multiple tags (the selected fillet should become a separate
• Fix Selection Types
• click on fillet and hit delete key deletes fillet
• click on fillet selects it and allows editing
• rename addTagForSketchOnFace
• make eslint happy: // eslint-disable-next-line @typescript-eslint/no-floating-promises . Example: internal: Add lints for promises #3733
• make sure fillet works also with the cases when extrude is in the sketch pipe
• add support for selecting edges of existing fillets
• fillet the chamfer and vice versa
• double check support for getCommonEdge. Reference: New StdLib function getCommonEdge #4070
• Move Fillet expression into a separate pipe
• Refactor Point and Click tests a bit so colors are universal

multiple selections

• Pull out updateAstAndFocus in order to make unit tests for applyFilletToSelection #3831
• AST Fillet mod for Selecting Multiple Edges #3680
• getSelectionType needs improvement for handling multiple types and selections #3834
• add multiple selections support for focusPath #3943

command bar

• add some indication of valid / not valid selections , related to Strange Offset Behavior With patternCircular2d #2612
• add dry-run support dry_run

notes

• refactor addAst

closed

• add edges to Artifact Graph (Fillet UI related) #3331

[max-mrgrsk]

I wonder what is a best visual solution in the viewport for conflict between fillets. First idea is to mark the edge with failed fillet with a red colour or an exclamation mark.