Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing stdlib function to get array length #4807

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guptaarnav
Copy link
Collaborator

Closes #4804.

Changes some existing tests to not use the word 'len'.

Copy link

qa-wolf bot commented Dec 15, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Dec 15, 2024 9:10pm

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.01%. Comparing base (04e586d) to head (d4ebddf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/std/array.rs 75.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4807      +/-   ##
==========================================
- Coverage   86.01%   86.01%   -0.01%     
==========================================
  Files          84       84              
  Lines       30023    30052      +29     
==========================================
+ Hits        25825    25849      +24     
- Misses       4198     4203       +5     
Flag Coverage Δ
wasm-lib 86.01% <82.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to get length of an array
1 participant