Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for float numbers in rem() arguments #4858

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jtran
Copy link
Collaborator

@jtran jtran commented Dec 23, 2024

Resolves #4818.

The new type is named NumberArg since it appears in docs. Ints are generally an implementation detail. But it also shouldn't conflict with the Number variant of KclValue, which is also in the docs.

Copy link

qa-wolf bot commented Dec 23, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Dec 23, 2024 5:32pm

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.81%. Comparing base (bb51646) to head (1b8ad08).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/std/args.rs 69.56% 7 Missing ⚠️
src/wasm-lib/kcl/src/std/math.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4858      +/-   ##
==========================================
- Coverage   85.84%   85.81%   -0.04%     
==========================================
  Files          86       86              
  Lines       30946    30964      +18     
==========================================
+ Hits        26566    26572       +6     
- Misses       4380     4392      +12     
Flag Coverage Δ
wasm-lib 85.81% <72.41%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remainder function rem() should work with float numbers
1 participant