Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clap should be an optional feature #79

Open
adamchalmers opened this issue Mar 21, 2023 · 0 comments
Open

Clap should be an optional feature #79

adamchalmers opened this issue Mar 21, 2023 · 0 comments

Comments

@adamchalmers
Copy link
Collaborator

adamchalmers commented Mar 21, 2023

twilio-api derives clap::ValueEnum here, which means any consumers of twilio-api need to compile clap. Clap is a really big crate, and consumers shouldn't be forced to compile clap unless they actually run a CLI.

Suggestion: twilio-api should have an optional Cargo feature for clap. Consumers who want CLI support can opt into it. Consumers (like api-deux) that don't need it, won't enable it, and won't have to compile clap.

@KittyCAD KittyCAD deleted a comment from org-projects-app bot Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant