Home

Notes on README.md

1. Does not explicitly say to make install. However, SPROKIT_DEFAULT_MODULE_PATHS=/usr/local/lib/sprokit, which assumes you did.
2. When I ran $processopedia -t numbers -d, I got Error: unknown option -t. processopedia --version returns
   sprokit
   Built with sprokit:
   Built from git: no
   Git hash:
   Dirty: no
3. https://github.com/Kitware/kwiver/blob/master/kwiver/pipeline_configs/number_flow.pipe is a broken link. I think it should be https://github.com/Kitware/kwiver/blob/master/sprokit/pipelines/number_flow.pipe
   a. Likewise, pipeline_runner -p </path/to/kwiver/source>/kwiver/pipeline_configs>/number_flow.pipe should be updated as well.
4. make install doesn't seem to respect SPROKIT_DEFAULT_CLUSTER_PATHS defined by cmake. The files don't get copied there.
5. ran $ pipeline_runner -S pythread_per_process -p /home/matt/libraries/kwiver/sprokit/pipelines/number_flow.pipe and got Exception caught: There is no such process of type 'numbers' in the registry.
6. https://github.com/Kitware/kwiver/blob/master/sprokit/processes/python/kw_print_number_process.py is a broken link. I think it should be https://github.com/Kitware/kwiver/blob/master/sprokit/processes/python/kw_print_number_process.py.
7. "building kwiver out of the source directory" might be clearer with out=outside for those unfamiliar with the term out-of-source build.
8. The section Running CMake, CMake Options,Dependencies, and Required seem out of place. It might make more sense further up near Building KWIVER, or maybe I am missing something about the intended flow. Also, Vital's place in the hierarchy wasn't really clear.
9. Sprokit is a broken link.
10. ".pipe" file is very similar is a broken link.