Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synapse >=1.92 does not return a python_version #8

Open
nerdoc opened this issue Dec 6, 2023 · 0 comments
Open

synapse >=1.92 does not return a python_version #8

nerdoc opened this issue Dec 6, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@nerdoc
Copy link

nerdoc commented Dec 6, 2023

using Management.version(), it should return a server_version and python_version.
But since synapse 1.94.0 it does not return a python_version in the JSON.

So your code produces an error.

I would also remove the python_version from the code. This may be backwards incompatible. You could also remove the python str from SynapseVersion (even more incompatible then 😆 ).

Best way would be to check if the server_version is < 1.94.0, and if yes, include python_version. if higher, skip it.

@KnugiHK KnugiHK added the bug Something isn't working label Dec 7, 2023
@KnugiHK KnugiHK self-assigned this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants