Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation and contrast issues #337

Open
xavierfiechter opened this issue Feb 15, 2023 · 7 comments
Open

Translation and contrast issues #337

xavierfiechter opened this issue Feb 15, 2023 · 7 comments
Labels
enhancement New feature or request javascript Pull requests that update Javascript code ready to release

Comments

@xavierfiechter
Copy link
Contributor

Screenshot_20230215-224652
Screenshot_20230215-224705

A: better contrast needed
B: "Adresse"
C: "Meine Relays"
D: better contrast needed
E: "Einen Fehler melden"
F: "Kontakte"

@123vier @KoalaSat

@KoalaSat KoalaSat added enhancement New feature or request javascript Pull requests that update Javascript code labels Feb 15, 2023
@123vier
Copy link
Contributor

123vier commented Feb 16, 2023

Thank you, I'm taking care of this
Danke

@123vier
Copy link
Contributor

123vier commented Feb 16, 2023

@KoalaSat for the issues in the first picture, the main menu, translation already exists, I compared it with en.json and all items are translated. I only noticed that one line was in a different order and corrected this, but as far as I know this shouldn't make a difference inside this section. If there's a syntax error, I cannot find it.

"menuItems": {
"relays": "Relays",
"contacts": "Kontakte",
"notConnected": "Nicht verbunden",
"connectedRelays": "{{number}} verbunden",
"following": "{{following}} folge ich",
"followers": "{{followers}} folgen mir",
"configuration": "Einstellungen",
"about": "Über Nostros",
"contacts": "Kontakte",
"reportBug": "Bug melden",
"logout": "Abmelden"
},

@123vier
Copy link
Contributor

123vier commented Feb 16, 2023

same issue with

"myList": "Meine Relays",

it shows the text from the en.json

"myList": "My relays",

@123vier
Copy link
Contributor

123vier commented Feb 16, 2023

@FrontendCrypto can you have a look at the contrast of these items in the screenshot, labeled A and D please?

thanks

@devsigner-xyz
Copy link
Contributor

Yes, I think that is a problem. I have designed it differently. Not implemented as in design.

Screenshot_2023-02-16-10-09-43-093_com.figma.mirror.jpg

@KoalaSat
Copy link
Owner

All this should be fixed with the latest version

@xavierfiechter
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code ready to release
Projects
None yet
Development

No branches or pull requests

4 participants