Error Adding zones/regiosn on Aqara FP1 (RTCZCGQ11LM)

[kikecortes6]

This part of the code always returns 00:00:00:00:ff at the end making impossible to create new zones

this part is the trigger

zigbee-herdsman-converters/src/lib/lumi.ts

Line 3427 in dbf535c

const sortedZonesWithSets: {[s: number]: [number]} = command.zones

but this part is the problem:

zigbee-herdsman-converters/src/lib/lumi.ts

Line 3449 in dbf535c

deviceConfig[0] = presence.constants.region_config_cmds.create;

const sortedZonesWithSets: {[s: number]: [number]} = command.zones
.reduce(
(accumulator: {[s: number]: Set}, zone: {x: number, y: number}) => {
if (!accumulator[zone.y]) {
accumulator[zone.y] = new Set();
}

                    accumulator[zone.y].add(zone.x);

                    return accumulator;
                },
                sortedZonesAccumulator,
            );
        const sortedZones = Object.entries(sortedZonesWithSets).reduce((acc, [key, value]) => {
            const numKey = parseInt(key, 10); // Convert string key back to number
            acc[numKey] = Array.from(value);
            return acc;
        }, {} as {[s: number]: number[]});

        const deviceConfig = new Uint8Array(7);

        // Command parameters
        deviceConfig[0] = presence.constants.region_config_cmds.create;
        deviceConfig[1] = command.region_id;
        deviceConfig[6] = presence.constants.region_config_cmd_suffix_upsert;
        // Zones definition
        deviceConfig[2] |= presence.encodeXCellsDefinition(sortedZones['1']);
        deviceConfig[2] |= presence.encodeXCellsDefinition(sortedZones['2']) << 4;
        deviceConfig[3] |= presence.encodeXCellsDefinition(sortedZones['3']);
        deviceConfig[3] |= presence.encodeXCellsDefinition(sortedZones['4']) << 4;
        deviceConfig[4] |= presence.encodeXCellsDefinition(sortedZones['5']);
        deviceConfig[4] |= presence.encodeXCellsDefinition(sortedZones['6']) << 4;
        deviceConfig[5] |= presence.encodeXCellsDefinition(sortedZones['7']);

        log('info', `create region ${command.region_id} ${printNumbersAsHexSequence([...deviceConfig], 2)}`);

        const payload = {
            [presence.constants.region_config_write_attribute]: {
                value: deviceConfig,
                type: presence.constants.region_config_write_attribute_type,
            },
        };

They variable sortedZones returns data, i had test it , the problem with the code is this one:

    deviceConfig[2] |= presence.encodeXCellsDefinition(sortedZones['1']);
    deviceConfig[2] |= presence.encodeXCellsDefinition(sortedZones['2']) << 4;
    deviceConfig[3] |= presence.encodeXCellsDefinition(sortedZones['3']);
    deviceConfig[3] |= presence.encodeXCellsDefinition(sortedZones['4']) << 4;
    deviceConfig[4] |= presence.encodeXCellsDefinition(sortedZones['5']);
    deviceConfig[4] |= presence.encodeXCellsDefinition(sortedZones['6']) << 4;
    deviceConfig[5] |= presence.encodeXCellsDefinition(sortedZones['7']);

fills all these with 0

[kikecortes6]

I think I found the problem is in here

zigbee-herdsman-converters/src/lib/lumi.ts

Line 888 in dbf535c

encodeXCellsDefinition: (xCells?: number[]): number => {

, not sure why xCells is trying to use .size property I think is wrong, I think the correct way is to access .length property, if not please let me know why this peace of code uses .size property.

I will like to suggest this modification:

and here is an example of the code running:

code

[Koenkk]

Should be length indeed, could you make a pull request?

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days