Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbac_user_service to add return status code #429

Open
reskin89 opened this issue Mar 27, 2024 · 1 comment
Open

rbac_user_service to add return status code #429

reskin89 opened this issue Mar 27, 2024 · 1 comment

Comments

@reskin89
Copy link

In this code it would be nice to update the func signature to something like:

func (s *RBACUserService) Get(ctx context.Context,
	nameOrID *string,
) (*RBACUser, int, error) {

where int is the status code returned from the kong api.

It makes handling of certain error scenarios when importing this library a lot easier to manage and tailor toward the importing application.

@reskin89
Copy link
Author

I'll add here that it's probably a good idea in this situation if accepted, that the status code or certain other pieces of the response body as an object are returned if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant