From 1059a0ab410af549a58f3811ce42f3079a13ffd0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Grzegorz=20Burzy=C5=84ski?= Date: Fri, 8 Dec 2023 14:58:32 +0100 Subject: [PATCH] chore(ci): don't fix linting issues in CI (#5314) --- .github/workflows/_linters.yaml | 3 +++ Makefile | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/_linters.yaml b/.github/workflows/_linters.yaml index af8ddbe4a6..98161b1ac3 100644 --- a/.github/workflows/_linters.yaml +++ b/.github/workflows/_linters.yaml @@ -18,6 +18,9 @@ jobs: go-version-file: third_party/go.mod - name: Run lint + env: + # Our .golangci.yaml has fix: true, but we don't want that in CI therefore the below override. + GOLANGCI_LINT_FLAGS: "--fix=false" run: make lint - name: Verify manifest consistency diff --git a/Makefile b/Makefile index fcdb441719..891b72fe05 100644 --- a/Makefile +++ b/Makefile @@ -161,7 +161,7 @@ lint: verify.tidy golangci-lint staticcheck looppointer .PHONY: golangci-lint golangci-lint: golangci-lint.download - $(GOLANGCI_LINT) run --verbose --config $(PROJECT_DIR)/.golangci.yaml + $(GOLANGCI_LINT) run --verbose --config $(PROJECT_DIR)/.golangci.yaml $(GOLANGCI_LINT_FLAGS) .PHONY: staticcheck staticcheck: staticcheck.download