Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSMessageView position when calling status bar is on screen #130

Open
ghost opened this issue Apr 3, 2014 · 9 comments · May be fixed by #208
Open

TSMessageView position when calling status bar is on screen #130

ghost opened this issue Apr 3, 2014 · 9 comments · May be fixed by #208
Labels
bug

Comments

@ghost
Copy link

ghost commented Apr 3, 2014

When there is a connection sharing or a phone call on the iPhone, that adds an "incall status bar" of 20 pt to the NavigationBar. If there is a TSMessage during that time, the message is offset by 20 pts down, therefore not "attached" to the navigationBar anymore.

See pictures attached
Picture 1 : table VC (no message)
Picture 2 : table VC with TSMessage
Picture 3 : table VC with TS message with call status bar : oups !!

picture 1

picture 2

picture 3
@mRs-
Copy link
Collaborator

mRs- commented Apr 3, 2014

this should be easy to fix.

i will look into this.

@mRs- mRs- self-assigned this Apr 3, 2014
@mRs- mRs- added the bug label Apr 3, 2014
@ghost
Copy link
Author

ghost commented Apr 3, 2014

Thanks Marius !

Best regards,
Frédéric

Le 3 avr. 2014 à 14:55, Marius Landwehr [email protected] a écrit :

this should be easy to fix.

i will look into this.

—
Reply to this email directly or view it on GitHub.

@KrauseFx
Copy link
Owner

KrauseFx commented Apr 3, 2014

Thanks Marius 👍

@ghost
Copy link
Author

ghost commented Apr 22, 2014

Hi Marius,
Any news about this bug ?

Thanks for the update
Fred

@ghost ghost closed this as completed Apr 22, 2014
@ghost ghost reopened this Apr 22, 2014
@mRs-
Copy link
Collaborator

mRs- commented Apr 22, 2014

I'm working on this bug as soon i'm hitting the implementation of TSMessages in my current project.

The ETA is one week.

@ghost
Copy link
Author

ghost commented Apr 22, 2014

Cool, thanks !

Le 22 avr. 2014 à 13:34, Marius Landwehr [email protected] a écrit :

I'm working on this bug as soon i'm hitting the implementation of TSMessages in my current project.

The ETA is one week.

—
Reply to this email directly or view it on GitHub.

@KrauseFx KrauseFx mentioned this issue Aug 27, 2014
Closed
@KrauseFx
Copy link
Owner

KrauseFx commented Nov 3, 2014

I just added a new version, where you have full control of the vertical position of your message view.
All you have to do is implement the delegate method and return the correct y position of your view.

Check out the commit here: 36522b1
You have to update to the latest version on master. When you're using Cocoapods, just add
pod "TSMessages", :head

I'll release a new update on cocoapods later today.
Please let me know if this fixes the problem.

@ghost
Copy link
Author

ghost commented Nov 3, 2014

Thanks Felix !

Hem ... how exactly would I use this new function to take into account the call status bar height ?
Thanks

Regards,
Frédéric

Le 3 nov. 2014 à 14:23, Felix Krause [email protected] a écrit :

I just added a new version, where you have full control of the vertical position of your message view.
All you have to do is implement the delegate method and return the correct y position of your view.

Check out the commit here: 36522b1 36522b1
You have to update to the latest version on master. When you're using Cocoapods, just add
pod "TSMessages", :head

I'll release a new update on cocoapods later today.
Please let me know if this fixes the problem.

—
Reply to this email directly or view it on GitHub #130 (comment).

@mRs- mRs- closed this as completed Nov 10, 2014
@KrauseFx KrauseFx reopened this Nov 10, 2014
@KrauseFx
Copy link
Owner

I haven't had time to answer that yet. They is some method to get the current status bar height.
Let me know if you can't find it.

@ghost ghost unassigned mRs- Jan 14, 2015
@jlorich jlorich linked a pull request Mar 2, 2015 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to using topLayoutGuide to determine vertical offset jlorich/TSMessages
2 participants
@mRs- @KrauseFx