Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working properly when the user is browsing the laravel 5 application in private #7

Open
stoyo opened this issue Mar 21, 2016 · 1 comment

Comments

@stoyo
Copy link

stoyo commented Mar 21, 2016

First of all, great package. It is easy to use and it works like a charm.

However, I jut noticed that when I access a page from my web application in incognito mode the counter activates as if I am a new user. This happens every time. Are you planning on updating the package anytime soon in terms of handling this?

@stoyo stoyo changed the title Not working properly in incognito mode Not working properly when the user is browsing the web application in private Mar 21, 2016
@stoyo stoyo changed the title Not working properly when the user is browsing the web application in private Not working properly when the user is browsing the laravel 5 web application in private Mar 21, 2016
@stoyo stoyo changed the title Not working properly when the user is browsing the laravel 5 web application in private Not working properly when the user is browsing the laravel 5 application in private Mar 21, 2016
@Kryptonit3-zz
Copy link
Owner

This issue has always been a tough spot for any developer that creates "tracking" software. This package relies heavily on a "forever" cookie. We fall back to IP address when a developer uses route caching and our package route hasn't been loaded.

https://github.com/Kryptonit3/Counter/blob/master/src/Counter.php#L153-L166

I am open to ideas on how to better implement a unique hit that doesn't rely as much on cookies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants