Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Floating point values in integer conditions table #66

Closed
EinarElen opened this issue Sep 14, 2023 · 5 comments
Closed

Floating point values in integer conditions table #66

EinarElen opened this issue Sep 14, 2023 · 5 comments

Comments

@EinarElen
Copy link
Contributor

We have a minor bug in one of the hardcoded conditions. The TrigPrimConditions table expects integers but TOT_GAIN is currently set to 2.5. This will, presumably, just get narrowed to 2. We could either just change it to be 2 or change the table to expect floating point numbers.

See LDMX-Software/ldmx-sw#1199 and LDMX-Software/ldmx-sw#1198 (comment) for some context

@therwig what do you think is best?

@therwig
Copy link
Contributor

therwig commented Sep 14, 2023

Thanks for catching this. I defer to the hcal experts, but assuming floating point gain values are reasonable I'd suggest updating the type.

@EinarElen
Copy link
Contributor Author

Seems reasonable to me.

@tomeichlersmith
Copy link
Member

tomeichlersmith commented Sep 14, 2023

Floating point gain values are not reasonable for trigger primitives.

I think the gain should be rounded to an integer for trigger primitives in order to reflect the fact that in the chip preparing the information for the trigger we do not plan to have floating point operations.

@EinarElen
Copy link
Contributor Author

Then I suggest we do the rounding explicitly in the configuration

@EinarElen
Copy link
Contributor Author

EinarElen commented Oct 31, 2023

Closed by PR #70

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants