This repository has been archived by the owner on May 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Floating point values in integer conditions table #66
Comments
Thanks for catching this. I defer to the hcal experts, but assuming floating point gain values are reasonable I'd suggest updating the type. |
Seems reasonable to me. |
Floating point gain values are not reasonable for trigger primitives. I think the gain should be rounded to an integer for trigger primitives in order to reflect the fact that in the chip preparing the information for the trigger we do not plan to have floating point operations. |
Then I suggest we do the rounding explicitly in the configuration |
Closed by PR #70 |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We have a minor bug in one of the hardcoded conditions. The
TrigPrimConditions
table expects integers butTOT_GAIN
is currently set to 2.5. This will, presumably, just get narrowed to 2. We could either just change it to be 2 or change the table to expect floating point numbers.See LDMX-Software/ldmx-sw#1199 and LDMX-Software/ldmx-sw#1198 (comment) for some context
@therwig what do you think is best?
The text was updated successfully, but these errors were encountered: