Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Support GRPC over Tor. #368

Open
Kixunil opened this issue Apr 7, 2021 · 0 comments
Open

Support GRPC over Tor. #368

Kixunil opened this issue Apr 7, 2021 · 0 comments

Comments

@Kixunil
Copy link

Kixunil commented Apr 7, 2021

Is your feature request related to a problem? Please describe.
The wallet currently uses different QR codes for Android and iOS, which leads to UX issues and developer churn. The user needs to know what platform and protocol is being used and select it when generating QR code, the developer must know about this (poorly documented) limitation implement it and test it.

Describe the solution you'd like
Just support GRPC everywhere.

Describe alternatives you've considered

  • Supporting REST everywhere instead could be an option but GRPC is more efficient so should be the best. It'd also require migrating GRPC clients.
  • Supporting both with auto-detection would be nice but perhaps too complicated?
  • Keeping sad UX as is - that'd be a real shame as Zap is great otherwise.
  • If this is too complicated, the lndconnect link could be extended to specify both GRPC and REST. Then Zap could just use the relevant protocol.

Additional context
Yeah, I've just spent around an hour on solving this and in parallel was designing some GUI around QR code which now needs to be redesigned unless this is resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant