Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web process crash with Bandcamp iframe and width above a certain limit #1749

Open
Hamcha opened this issue Oct 12, 2024 · 0 comments
Open

Web process crash with Bandcamp iframe and width above a certain limit #1749

Hamcha opened this issue Oct 12, 2024 · 0 comments
Labels
bug Something isn't working has repro We have a way to reproduce this bug. layout reduction of web content Issue has a simplified reduction based on real-world web content. web compatibility

Comments

@Hamcha
Copy link

Hamcha commented Oct 12, 2024

The following page:

<iframe
	src="https://bandcamp.com/EmbeddedPlayer/size=small/track=52352246/"
	style="width:100%;">
</iframe>

crashes the web renderer with this:

VERIFICATION FAILED: m_has_value at /mnt/c/projects/ladybird/AK/Optional.h:213
/mnt/c/projects/ladybird/Build/ladybird/libexec/../lib/liblagom-ak.so.0(ak_verification_failed+0xef) [0x7fded41c535f]
/mnt/c/projects/ladybird/Build/ladybird/libexec/../lib/liblagom-web.so.0(+0x9a993a) [0x7fded824593a]
/mnt/c/projects/ladybird/Build/ladybird/libexec/../lib/liblagom-web.so.0 Web::Layout::FormattingContext::layout_absolutely_positioned_element(Web::Layout::Box const&, Web::Layout::AvailableSpace const&) 0x23e) [0x7fded824132e]
/mnt/c/projects/ladybird/Build/ladybird/libexec/../lib/liblagom-web.so.0 Web::Layout::BlockFormattingContext::parent_context_did_dimension_child_root_box() 0x21e) [0x7fded821f5ce]
/mnt/c/projects/ladybird/Build/ladybird/libexec/../lib/liblagom-web.so.0 Web::Layout::FormattingContext::layout_absolutely_positioned_element(Web::Layout::Box const&, Web::Layout::AvailableSpace const&) 0x3fc) [0x7fded82414ec]
/mnt/c/projects/ladybird/Build/ladybird/libexec/../lib/liblagom-web.so.0 Web::Layout::BlockFormattingContext::parent_context_did_dimension_child_root_box() 0x21e) [0x7fded821f5ce]
/mnt/c/projects/ladybird/Build/ladybird/libexec/../lib/liblagom-web.so.0 Web::Layout::FormattingContext::layout_absolutely_positioned_element(Web::Layout::Box const&, Web::Layout::AvailableSpace const&) 0x3fc) [0x7fded82414ec]
<cut>

From what I could test, it crashes when width, specified as either CSS or through the width attribute, is set to a value that's higher than some specific one (in my case, 369px is the limit, and anything above will crash). Other style attributes like height don't affect this.

@AtkinsSJ AtkinsSJ added bug Something isn't working reduction of web content Issue has a simplified reduction based on real-world web content. has repro We have a way to reproduce this bug. web compatibility layout labels Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has repro We have a way to reproduce this bug. layout reduction of web content Issue has a simplified reduction based on real-world web content. web compatibility
Projects
None yet
Development

No branches or pull requests

2 participants