From 2c0178b4ab42591955fd4ec44aa931659335f08e Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Mon, 30 Sep 2024 14:41:54 -0700 Subject: [PATCH 1/8] feat: bump max eigenda batch size --- arbnode/batch_poster.go | 2 +- eigenda/eigenda.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arbnode/batch_poster.go b/arbnode/batch_poster.go index b6631b4cf..03147dd13 100644 --- a/arbnode/batch_poster.go +++ b/arbnode/batch_poster.go @@ -245,7 +245,7 @@ var DefaultBatchPosterConfig = BatchPosterConfig{ DisableDapFallbackStoreDataOnChain: false, // This default is overridden for L3 chains in applyChainParameters in cmd/nitro/nitro.go MaxSize: 100000, - MaxEigenDABatchSize: 2_000_000, + MaxEigenDABatchSize: 16_000_000, // Try to fill 3 blobs per batch Max4844BatchSize: blobs.BlobEncodableData*(params.MaxBlobGasPerBlock/params.BlobTxBlobGasPerBlob)/2 - 2000, PollInterval: time.Second * 10, diff --git a/eigenda/eigenda.go b/eigenda/eigenda.go index 85acb5edb..02e5b172f 100644 --- a/eigenda/eigenda.go +++ b/eigenda/eigenda.go @@ -11,7 +11,7 @@ import ( const ( sequencerMsgOffset = 41 - MaxBatchSize = 2_000_000 // 2MB + MaxBatchSize = 16_000_000 // 16MB ) func IsEigenDAMessageHeaderByte(header byte) bool { From ae2fe4faf643dd50d1a08964b520c70833f35f26 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Mon, 30 Sep 2024 14:43:42 -0700 Subject: [PATCH 2/8] feat: bump max eigenda batch size - bump testnode --- nitro-testnode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nitro-testnode b/nitro-testnode index cd3d33efa..250516c8e 160000 --- a/nitro-testnode +++ b/nitro-testnode @@ -1 +1 @@ -Subproject commit cd3d33efa722c5477ba2a300dbfd563de8317b71 +Subproject commit 250516c8ebef2167e3328ef8522ba772ccf9869e From 55134f0d61401329f2d90c0e5f2d6f8edb82c250 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Tue, 1 Oct 2024 23:01:24 -0700 Subject: [PATCH 3/8] feat: bump max eigenda batch size - increase MaxDecompressedLen --- arbstate/inbox.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arbstate/inbox.go b/arbstate/inbox.go index 6d71b5580..1d27b7dcc 100644 --- a/arbstate/inbox.go +++ b/arbstate/inbox.go @@ -45,7 +45,7 @@ type sequencerMessage struct { segments [][]byte } -const MaxDecompressedLen int = 1024 * 1024 * 16 // 16 MiB +const MaxDecompressedLen int = 1024 * 1024 * 16 * 40 // 40 MiB const maxZeroheavyDecompressedLen = 101*MaxDecompressedLen/100 + 64 const MaxSegmentsPerSequencerMessage = 100 * 1024 From 65dfc248177e721d4b2d47cd9ff1a45bec8b5488 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Wed, 2 Oct 2024 02:41:40 -0700 Subject: [PATCH 4/8] feat: bump max eigenda batch size - update shellcheck ci to use custom runner --- .github/workflows/shellcheck-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/shellcheck-ci.yml b/.github/workflows/shellcheck-ci.yml index d1c7b5858..01625204e 100644 --- a/.github/workflows/shellcheck-ci.yml +++ b/.github/workflows/shellcheck-ci.yml @@ -12,7 +12,7 @@ on: jobs: shellcheck: name: Run ShellCheck - runs-on: ubuntu-8 + runs-on: linux-2xl steps: - name: Checkout uses: actions/checkout@v4 From b7b71ac3807ec9507c4b8e3b16f9f69940b084a4 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Wed, 2 Oct 2024 02:43:25 -0700 Subject: [PATCH 5/8] feat: bump max eigenda batch size - update proxy start script --- scripts/start-eigenda-proxy.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/start-eigenda-proxy.sh b/scripts/start-eigenda-proxy.sh index 0a921a04a..de349980e 100755 --- a/scripts/start-eigenda-proxy.sh +++ b/scripts/start-eigenda-proxy.sh @@ -1,3 +1,5 @@ +#!/usr/bin/env bash + echo "Pull eigenda-proxy container" docker pull ghcr.io/layr-labs/eigenda-proxy@sha256:10a4762f5c43e9037835617e6ec0b03da34012df87048a363f43b969ab93679b From 620fdcc3527fb102e648ee0060df0f9fe8adf03d Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Wed, 2 Oct 2024 12:41:44 -0700 Subject: [PATCH 6/8] feat: bump max eigenda batch size - update maxDecompressedLen --- arbstate/inbox.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arbstate/inbox.go b/arbstate/inbox.go index 1d27b7dcc..96c5c2bd7 100644 --- a/arbstate/inbox.go +++ b/arbstate/inbox.go @@ -45,7 +45,7 @@ type sequencerMessage struct { segments [][]byte } -const MaxDecompressedLen int = 1024 * 1024 * 16 * 40 // 40 MiB +const MaxDecompressedLen int = 1024 * 1024 * 40 // 40 MiB const maxZeroheavyDecompressedLen = 101*MaxDecompressedLen/100 + 64 const MaxSegmentsPerSequencerMessage = 100 * 1024 From 93389d9b3dd7abc6a287b7fabc75f3bf33ed9b9c Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Mon, 7 Oct 2024 17:58:05 -0400 Subject: [PATCH 7/8] feat: bump max eigenda batch size - mb to mib --- arbnode/batch_poster.go | 2 +- eigenda/eigenda.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arbnode/batch_poster.go b/arbnode/batch_poster.go index 03147dd13..0d5a415a6 100644 --- a/arbnode/batch_poster.go +++ b/arbnode/batch_poster.go @@ -245,7 +245,7 @@ var DefaultBatchPosterConfig = BatchPosterConfig{ DisableDapFallbackStoreDataOnChain: false, // This default is overridden for L3 chains in applyChainParameters in cmd/nitro/nitro.go MaxSize: 100000, - MaxEigenDABatchSize: 16_000_000, + MaxEigenDABatchSize: 16_777_216, // Try to fill 3 blobs per batch Max4844BatchSize: blobs.BlobEncodableData*(params.MaxBlobGasPerBlock/params.BlobTxBlobGasPerBlob)/2 - 2000, PollInterval: time.Second * 10, diff --git a/eigenda/eigenda.go b/eigenda/eigenda.go index 02e5b172f..eeead5f08 100644 --- a/eigenda/eigenda.go +++ b/eigenda/eigenda.go @@ -11,7 +11,7 @@ import ( const ( sequencerMsgOffset = 41 - MaxBatchSize = 16_000_000 // 16MB + MaxBatchSize = 16_777_216 // 16MiB ) func IsEigenDAMessageHeaderByte(header byte) bool { From 1430dcce385aa46fb30c2d086bda342ddbe52928 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Mon, 7 Oct 2024 18:00:46 -0400 Subject: [PATCH 8/8] feat: bump max eigenda batch size - only build ghcr containers when triggered manually --- .github/workflows/docker-eigenda.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/docker-eigenda.yml b/.github/workflows/docker-eigenda.yml index 27e0f3f39..824609c42 100644 --- a/.github/workflows/docker-eigenda.yml +++ b/.github/workflows/docker-eigenda.yml @@ -1,8 +1,6 @@ name: Build nitro-eigenda Docker Image on: workflow_dispatch: - push: - tags: ['*'] jobs: docker: