Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugin references from funktionen.conf (or move important ones over to wollmux core) #5

Open
thorstenb opened this issue Jan 21, 2023 · 1 comment

Comments

@thorstenb
Copy link
Contributor

Current sample config hits errors for a number of pre-configured templates (like external or internal letter heads):

de.muenchen.allg.itd51.wollmux.config.ConfigurationErrorException: Script "java:de.muenchen.allg.itd51.wollmux.func.Standard.formatiereTelefonnummerDIN5008Intern" not available

de.muenchen.allg.itd51.wollmux.config.ConfigurationErrorException: Script "java:de.muenchen.allg.itd51.wollmux.func.Standard.zahlenBereich" not available

Code for that is in .wollmux/config/plugins/de/muenchen/allg/itd51/wollmux/func/Standard.java but at least the phone number functions openly admit to be Munich-specific.

My take:

  • split wollmux config into sample (or example) bits, and core config
  • cleanse sample templates from any custom functions
  • move generally useful stuff (like regexp, zahlenBereich (after translation)) into Wollmux core

But whatever sits in the default wollmux-config archive should be running w/o errors out of the box.

@thorstenb
Copy link
Contributor Author

This is to say, the plugin concept is useful & powerful, and should be retained. Reference to plugin functions should be relegated to either documentation, or 'sample config' that is not part of the default config archive

thorstenb added a commit that referenced this issue Jan 21, 2023
Currently, funktionen.conf references a number of 'plugin'
functionality, some of which we've got Java sources for. Compile &
stick them into classes.jar, where the current config expects them.

Once #5 is resolved, probably this will have moved into WollMux core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant