Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mary Mother of God does not have Proper #244

Open
JohnRDOrazio opened this issue Nov 9, 2024 · 2 comments
Open

[Bug]: Mary Mother of God does not have Proper #244

JohnRDOrazio opened this issue Nov 9, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@JohnRDOrazio
Copy link
Member

JohnRDOrazio commented Nov 9, 2024

What happened?

Mary Mother of God, being a solemnity, has it's own Proper. However, the common and common_lcl properties seem to be empty?

Version

dev (Edge)

Which browser or browsers are you seeing the problem on? (can select more than one, or N/A if not applicable)

N/A

Relevant error messages

No response

@JohnRDOrazio JohnRDOrazio self-assigned this Nov 9, 2024
@JohnRDOrazio JohnRDOrazio added this to the v4.0 milestone Nov 9, 2024
@JohnRDOrazio JohnRDOrazio changed the title [Bug]: Mary Mother of the Church does not have Proper [Bug]: Mary Mother of God does not have Proper Nov 9, 2024
@JohnRDOrazio
Copy link
Member Author

Wow, examining current results it seems that many celebrations do not have a common or common_lcl defined:

[
    "Advent1_vigil",
    "Advent1",
    "AdventWeekday1",
    "AdventWeekday2",
    "AdventWeekday3",
    "AdventWeekday4",
    "AdventWeekday6",
    "Advent2_vigil",
    "Advent2",
    "AdventWeekday8",
    "AdventWeekday9",
    "AdventWeekday10",
    "AdventWeekday11",
    "AdventWeekday12",
    "AdventWeekday13",
    "Advent3_vigil",
    "Advent3",
    "AdventWeekday15",
    "AdventWeekday16",
    "AdventWeekday17",
    "AdventWeekday18",
    "AdventWeekday19",
    "AdventWeekday20",
    "Advent4_vigil",
    "Advent4",
    "Christmas_vigil",
    "Christmas",
    "ChristmasWeekday4",
    "ChristmasWeekday5",
    "HolyFamily_vigil",
    "HolyFamily",
    "MotherGod_vigil",
    "MotherGod",
    "DayBeforeEpiphany2",
    "DayBeforeEpiphany3",
    "DayBeforeEpiphany4",
    "Epiphany_vigil",
    "Epiphany",
    "BaptismLord",
    "FirstOrdWeekday1",
    "FirstOrdWeekday2",
    "FirstOrdWeekday3",
    "FirstOrdWeekday4",
    "FirstOrdWeekday5",
    "FirstOrdWeekday6",
    "OrdSunday2_vigil",
    "OrdSunday2",
    "FirstOrdWeekday8",
    "FirstOrdWeekday9",
    "FirstOrdWeekday11",
    "FirstOrdWeekday12",
    "FirstOrdWeekday13",
    "OrdSunday3_vigil",
    "OrdSunday3",
    "FirstOrdWeekday15",
    "FirstOrdWeekday16",
    "FirstOrdWeekday20",
    "OrdSunday4_vigil",
    "OrdSunday4",
    "FirstOrdWeekday22",
    "FirstOrdWeekday23",
    "FirstOrdWeekday25",
    "FirstOrdWeekday27",
    "OrdSunday5_vigil",
    "OrdSunday5",
    "FirstOrdWeekday31",
    "FirstOrdWeekday32",
    "FirstOrdWeekday33",
    "OrdSunday6_vigil",
    "OrdSunday6",
    "FirstOrdWeekday36",
    "FirstOrdWeekday37",
    "AshWednesday",
    "LentWeekday1",
    "LentWeekday2",
    "LentWeekday3",
    "Lent1_vigil",
    "Lent1",
    "LentWeekday5",
    "LentWeekday6",
    "LentWeekday7",
    "LentWeekday8",
    "LentWeekday9",
    "LentWeekday10",
    "Lent2_vigil",
    "Lent2",
    "LentWeekday12",
    "LentWeekday13",
    "LentWeekday14",
    "LentWeekday15",
    "LentWeekday16",
    "LentWeekday17",
    "Lent3_vigil",
    "Lent3",
    "LentWeekday19",
    "LentWeekday20",
    "LentWeekday21",
    "LentWeekday22",
    "LentWeekday23",
    "LentWeekday24",
    "Lent4_vigil",
    "Lent4",
    "LentWeekday26",
    "LentWeekday27",
    "LentWeekday28",
    "LentWeekday29",
    "LentWeekday30",
    "LentWeekday31",
    "Lent5_vigil",
    "Lent5",
    "LentWeekday33",
    "LentWeekday35",
    "LentWeekday36",
    "LentWeekday37",
    "LentWeekday38",
    "PalmSun_vigil",
    "PalmSun",
    "MonHolyWeek",
    "TueHolyWeek",
    "WedHolyWeek",
    "HolyThurs",
    "GoodFri",
    "EasterVigil",
    "Easter",
    "MonOctaveEaster",
    "TueOctaveEaster",
    "WedOctaveEaster",
    "ThuOctaveEaster",
    "FriOctaveEaster",
    "SatOctaveEaster",
    "Easter2_vigil",
    "Easter2",
    "EasterWeekday9",
    "EasterWeekday10",
    "EasterWeekday12",
    "EasterWeekday13",
    "Easter3_vigil",
    "Easter3",
    "EasterWeekday15",
    "EasterWeekday16",
    "EasterWeekday17",
    "EasterWeekday18",
    "EasterWeekday19",
    "EasterWeekday20",
    "Easter4_vigil",
    "Easter4",
    "EasterWeekday22",
    "EasterWeekday23",
    "EasterWeekday24",
    "EasterWeekday26",
    "EasterWeekday27",
    "Easter5_vigil",
    "Easter5",
    "EasterWeekday30",
    "EasterWeekday31",
    "EasterWeekday34",
    "Easter6_vigil",
    "Easter6",
    "EasterWeekday36",
    "EasterWeekday37",
    "EasterWeekday38",
    "Ascension_vigil",
    "Ascension",
    "EasterWeekday40",
    "EasterWeekday41",
    "Easter7_vigil",
    "Easter7",
    "EasterWeekday43",
    "EasterWeekday45",
    "EasterWeekday46",
    "EasterWeekday47",
    "EasterWeekday48",
    "Pentecost_vigil",
    "Pentecost",
    "LastOrdWeekday2",
    "LastOrdWeekday3",
    "LastOrdWeekday4",
    "LastOrdWeekday5",
    "LastOrdWeekday6",
    "Trinity_vigil",
    "Trinity",
    "LastOrdWeekday8",
    "LastOrdWeekday9",
    "LastOrdWeekday10",
    "CorpusChristi_vigil",
    "CorpusChristi",
    "OrdSunday9_vigil",
    "OrdSunday9",
    "LastOrdWeekday16",
    "LastOrdWeekday18",
    "SacredHeart_vigil",
    "SacredHeart",
    "ImmaculateHeart",
    "OrdSunday10_vigil",
    "OrdSunday10",
    "LastOrdWeekday22",
    "LastOrdWeekday24",
    "LastOrdWeekday26",
    "LastOrdWeekday27",
    "OrdSunday11_vigil",
    "OrdSunday11",
    "LastOrdWeekday29",
    "LastOrdWeekday30",
    "LastOrdWeekday31",
    "LastOrdWeekday32",
    "LastOrdWeekday34",
    "OrdSunday12_vigil",
    "OrdSunday12",
    "LastOrdWeekday37",
    "LastOrdWeekday38",
    "LastOrdWeekday39",
    "OrdSunday13",
    "LastOrdWeekday43",
    "LastOrdWeekday44",
    "LastOrdWeekday46",
    "LastOrdWeekday47",
    "LastOrdWeekday48",
    "OrdSunday14_vigil",
    "OrdSunday14",
    "LastOrdWeekday50",
    "LastOrdWeekday51",
    "LastOrdWeekday52",
    "LastOrdWeekday54",
    "LastOrdWeekday55",
    "OrdSunday15_vigil",
    "OrdSunday15",
    "LastOrdWeekday58",
    "LastOrdWeekday59",
    "LastOrdWeekday60",
    "LastOrdWeekday61",
    "LastOrdWeekday62",
    "OrdSunday16_vigil",
    "OrdSunday16",
    "LastOrdWeekday65",
    "LastOrdWeekday66",
    "LastOrdWeekday69",
    "OrdSunday17_vigil",
    "OrdSunday17",
    "LastOrdWeekday72",
    "LastOrdWeekday75",
    "LastOrdWeekday76",
    "OrdSunday18_vigil",
    "OrdSunday18",
    "LastOrdWeekday78",
    "LastOrdWeekday80",
    "LastOrdWeekday82",
    "OrdSunday19_vigil",
    "OrdSunday19",
    "LastOrdWeekday85",
    "LastOrdWeekday86",
    "LastOrdWeekday89",
    "LastOrdWeekday90",
    "OrdSunday20_vigil",
    "OrdSunday20",
    "LastOrdWeekday92",
    "LastOrdWeekday96",
    "OrdSunday21_vigil",
    "OrdSunday21",
    "LastOrdWeekday99",
    "LastOrdWeekday103",
    "LastOrdWeekday104",
    "OrdSunday22_vigil",
    "OrdSunday22",
    "LastOrdWeekday106",
    "LastOrdWeekday108",
    "LastOrdWeekday109",
    "LastOrdWeekday110",
    "LastOrdWeekday111",
    "OrdSunday23_vigil",
    "OrdSunday23",
    "LastOrdWeekday113",
    "LastOrdWeekday114",
    "LastOrdWeekday115",
    "LastOrdWeekday116",
    "OrdSunday24_vigil",
    "OrdSunday24",
    "LastOrdWeekday121",
    "LastOrdWeekday122",
    "LastOrdWeekday123",
    "OrdSunday25_vigil",
    "OrdSunday25",
    "LastOrdWeekday128",
    "LastOrdWeekday129",
    "LastOrdWeekday130",
    "LastOrdWeekday132",
    "OrdSunday26_vigil",
    "OrdSunday26",
    "LastOrdWeekday137",
    "LastOrdWeekday139",
    "OrdSunday27_vigil",
    "OrdSunday27",
    "LastOrdWeekday142",
    "LastOrdWeekday143",
    "LastOrdWeekday144",
    "LastOrdWeekday145",
    "LastOrdWeekday146",
    "OrdSunday28_vigil",
    "OrdSunday28",
    "LastOrdWeekday148",
    "LastOrdWeekday150",
    "LastOrdWeekday153",
    "OrdSunday29_vigil",
    "OrdSunday29",
    "LastOrdWeekday155",
    "LastOrdWeekday156",
    "LastOrdWeekday157",
    "LastOrdWeekday158",
    "LastOrdWeekday159",
    "LastOrdWeekday160",
    "OrdSunday30_vigil",
    "OrdSunday30",
    "LastOrdWeekday163",
    "LastOrdWeekday164",
    "LastOrdWeekday165",
    "OrdSunday31",
    "LastOrdWeekday170",
    "LastOrdWeekday171",
    "LastOrdWeekday172",
    "LastOrdWeekday173",
    "OrdSunday32_vigil",
    "OrdSunday32",
    "LastOrdWeekday178",
    "LastOrdWeekday179",
    "LastOrdWeekday180",
    "LastOrdWeekday181",
    "OrdSunday33_vigil",
    "OrdSunday33",
    "LastOrdWeekday183",
    "LastOrdWeekday184",
    "LastOrdWeekday185",
    "LastOrdWeekday188",
    "ChristKing_vigil",
    "ChristKing",
    "LastOrdWeekday190",
    "LastOrdWeekday191",
    "LastOrdWeekday192",
    "LastOrdWeekday193",
    "LastOrdWeekday194"
]

Should we expect a common or common_lcl property on these? Are they fine without one? Perhaps at least solemnities and feasts should have a value of Proper...

@JohnRDOrazio
Copy link
Member Author

JohnRDOrazio commented Nov 9, 2024

These are the celebrations that have a grade of 4 (=FEAST) or greater:

[
    "Advent1_vigil",
    "Advent1",
    "Advent2_vigil",
    "Advent2",
    "Advent3_vigil",
    "Advent3",
    "Advent4_vigil",
    "Advent4",
    "Christmas_vigil",
    "Christmas",
    "HolyFamily_vigil",
    "HolyFamily",
    "MotherGod_vigil",
    "MotherGod",
    "Epiphany_vigil",
    "Epiphany",
    "BaptismLord",
    "OrdSunday2_vigil",
    "OrdSunday2",
    "OrdSunday3_vigil",
    "OrdSunday3",
    "OrdSunday4_vigil",
    "OrdSunday4",
    "OrdSunday5_vigil",
    "OrdSunday5",
    "OrdSunday6_vigil",
    "OrdSunday6",
    "AshWednesday",
    "Lent1_vigil",
    "Lent1",
    "Lent2_vigil",
    "Lent2",
    "Lent3_vigil",
    "Lent3",
    "Lent4_vigil",
    "Lent4",
    "Lent5_vigil",
    "Lent5",
    "PalmSun_vigil",
    "PalmSun",
    "MonHolyWeek",
    "TueHolyWeek",
    "WedHolyWeek",
    "HolyThurs",
    "GoodFri",
    "EasterVigil",
    "Easter",
    "MonOctaveEaster",
    "TueOctaveEaster",
    "WedOctaveEaster",
    "ThuOctaveEaster",
    "FriOctaveEaster",
    "SatOctaveEaster",
    "Easter2_vigil",
    "Easter2",
    "Easter3_vigil",
    "Easter3",
    "Easter4_vigil",
    "Easter4",
    "Easter5_vigil",
    "Easter5",
    "Easter6_vigil",
    "Easter6",
    "Ascension_vigil",
    "Ascension",
    "Easter7_vigil",
    "Easter7",
    "Pentecost_vigil",
    "Pentecost",
    "Trinity_vigil",
    "Trinity",
    "CorpusChristi_vigil",
    "CorpusChristi",
    "OrdSunday9_vigil",
    "OrdSunday9",
    "SacredHeart_vigil",
    "SacredHeart",
    "OrdSunday10_vigil",
    "OrdSunday10",
    "OrdSunday11_vigil",
    "OrdSunday11",
    "OrdSunday12_vigil",
    "OrdSunday12",
    "OrdSunday13",
    "OrdSunday14_vigil",
    "OrdSunday14",
    "OrdSunday15_vigil",
    "OrdSunday15",
    "OrdSunday16_vigil",
    "OrdSunday16",
    "OrdSunday17_vigil",
    "OrdSunday17",
    "OrdSunday18_vigil",
    "OrdSunday18",
    "OrdSunday19_vigil",
    "OrdSunday19",
    "OrdSunday20_vigil",
    "OrdSunday20",
    "OrdSunday21_vigil",
    "OrdSunday21",
    "OrdSunday22_vigil",
    "OrdSunday22",
    "OrdSunday23_vigil",
    "OrdSunday23",
    "OrdSunday24_vigil",
    "OrdSunday24",
    "OrdSunday25_vigil",
    "OrdSunday25",
    "OrdSunday26_vigil",
    "OrdSunday26",
    "OrdSunday27_vigil",
    "OrdSunday27",
    "OrdSunday28_vigil",
    "OrdSunday28",
    "OrdSunday29_vigil",
    "OrdSunday29",
    "OrdSunday30_vigil",
    "OrdSunday30",
    "OrdSunday31",
    "OrdSunday32_vigil",
    "OrdSunday32",
    "OrdSunday33_vigil",
    "OrdSunday33",
    "ChristKing_vigil",
    "ChristKing"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant