Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor resource creation / updating via PUT/PATCH/DELETE requests #265

Open
JohnRDOrazio opened this issue Nov 20, 2024 · 5 comments
Open
Labels
Milestone

Comments

@JohnRDOrazio
Copy link
Member

Now that we have a router and better API routes / paths in place, we need to rethink the shape of requests on the various paths that are aimed at creating resources or updating resources or even deleting resources via PUT, PATCH, and DELETE requests.

This will need to be done in tandem with the frontend.

@JohnRDOrazio
Copy link
Member Author

@JohnRDOrazio
Copy link
Member Author

Related issue #150

@JohnRDOrazio
Copy link
Member Author

Issue #150 is now complete. Once this issue is closed we will be able to close #220 as well.

@JohnRDOrazio
Copy link
Member Author

In order to better proceed with this issue, we need to clearly define the shape of the requests on each resource path for each request method.

The shape of the request should be defined both here in the API and on the client / frontend side.

@JohnRDOrazio
Copy link
Member Author

JohnRDOrazio commented Dec 2, 2024

Here's a checklist to keep track of the state of things:

Roman Missal sanctorale data

  • /missals PUT
  • /missals/{missal_id} PATCH
  • /missals/{missal_id} DELETE

National Calendar data

  • /data/nation PUT
  • /data/nation/{country_id} PATCH
  • /data/nation/{country_id} DELETE

Diocesan Calendar data

  • /data/diocese PUT
  • /data/diocese/{diocese_id} PATCH
  • /data/diocese/{diocese_id} DELETE

Decrees of the Congregation for Divine Worship (for the General Roman Calendar)

  • /decrees PUT
  • /decrees/{decree_id} PATCH
  • /decrees/{decree_id} DELETE

Unit tests

  • /tests PUT
  • /tests/{test_id} PATCH
  • /tests/{test_id} DELETE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant