From c0e8d9d14fc1779b5f1a6ca75d2c6f067aabcda1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 9 Oct 2024 13:57:47 +0200 Subject: [PATCH] Updating Atata.WebDriverSetup and re-enabling Edge tests --- .../Tests/BasicVisualVerificationTests.cs | 2 +- Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs | 6 ++---- Lombiq.Tests.UI/Lombiq.Tests.UI.csproj | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs b/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs index 780c69b62..a2372dec0 100644 --- a/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs +++ b/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs @@ -55,7 +55,7 @@ public Task VerifyBlogImage() => // is the different rendering of text on each platform, but it can occur between different Linux distributions too. // Here: https://pandasauce.org/post/linux-fonts/ you can find a good summary about this from 2019, but still valid // in 2022. - [Theory, Chrome, Edge(Skip = "Until not resolved: https://github.com/atata-framework/atata-webdriversetup/issues/16")] + [Theory, Chrome, Edge] public Task VerifyNavbar(Browser browser) => ExecuteTestAfterSetupAsync( context => diff --git a/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs b/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs index da473c6ec..c410f92be 100644 --- a/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs +++ b/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs @@ -23,9 +23,7 @@ public MultiBrowserTests(ITestOutputHelper testOutputHelper) // First, let's see a test using Edge. While the default browser is Chrome if you don't set anything, all // ExecuteTest* methods can also accept a browser, if you want to use a different one. -#pragma warning disable xUnit1004 - [Fact(Skip = "Until not resolved: https://github.com/atata-framework/atata-webdriversetup/issues/16")] -#pragma warning restore xUnit1004 + [Fact] public Task AnonymousHomePageShouldExistWithEdge() => ExecuteTestAfterSetupAsync(NavbarIsCorrect, Browser.Edge); @@ -33,7 +31,7 @@ public Task AnonymousHomePageShouldExistWithEdge() => // tests. [Chrome] and [Edge] are input parameters of the test, and thus in effect, you have now two tests: // AnonymousHomePageShouldExistMultiBrowser once with Chrome, and once with Edge. See here for more info: // https://andrewlock.net/creating-parameterised-tests-in-xunit-with-inlinedata-classdata-and-memberdata/. - [Theory, Chrome, Edge(Skip = "Until not resolved: https://github.com/atata-framework/atata-webdriversetup/issues/16")] + [Theory, Chrome, Edge] public Task AnonymousHomePageShouldExistMultiBrowser(Browser browser) => ExecuteTestAfterSetupAsync(NavbarIsCorrect, browser); diff --git a/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj b/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj index 2b13c3ee0..3fc27d706 100644 --- a/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj +++ b/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj @@ -66,7 +66,7 @@ - +