-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility Issue with mkdocs-glightbox
#72
Comments
Thanks for raising this, it sounds like the ordering of the hooks matters. I'm not sure how MkDocs determines the precedence of plugins, but I wonder if reordering them in the Do you have an example I could clone to test? |
Unfortunately, changing the plugin order in A better solution would be to modify your plugin so that it updates the image link during the I'll try to create an example project when I find more time in my currently tight schedule. If possible, I'll also work on a pull request with the modifications I believe could solve the issue. |
I'm rewriting the images in Happy to accept a PR or take a look myself, time permitting 👍 |
Hello!
First of all, I have to say that your plugin has saved me a lot of time in converting Draw.io files to PNG.
I found an issue when using it alongside the mkdocs-glightbox plugin. This plugin wraps images with an anchor tag, using the image
src
as the anchorhref
. This occurs in theon_page_content
function, which means the anchor is added before your plugin modifies the imagesrc
inon_post_build
function (if I understand your code correctly).As a result, the anchor
href
remains broken, still pointing to the original.drawio
file rather than the generated.png
,.svg
, or other formats created by your plugin.The text was updated successfully, but these errors were encountered: