Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions. #15

Open
ErjieWu opened this issue Jan 11, 2023 · 0 comments
Open

Some suggestions. #15

ErjieWu opened this issue Jan 11, 2023 · 0 comments

Comments

@ErjieWu
Copy link
Contributor

ErjieWu commented Jan 11, 2023

  1. When we choose "confirm" pattern in phase_option in the second step (./light) without changing the parameter aznk_dir in INPUT.txt, there should be an error report about not finding the file. However there's no such report and the programme run normally by setting all input data as zero (maybe caused by the ifstream class).
  2. The index of Zernike polynomial in function zernike_cg in ./light/sources/Zernike.cpp doesn't match the index in function mnznk. Although it does not affect the outcome of the program, it is best to remove the ambiguity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant