Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomization of covariates not kept in sync with map during some edits. #63

Open
jmelott opened this issue Apr 20, 2023 · 8 comments
Open
Labels
2.21.3 bug Something isn't working show-stopper

Comments

@jmelott
Copy link
Contributor

jmelott commented Apr 20, 2023

To reproduce:
Create map with sample map.
Click on Advanced Features.
Use first row and column of sample matrix as continuous covariates.
Click new until on Covariates page
Add some additional covariates.
Click next until on Format Heat Map page.
Switch Format Tasks to Heat Map Display
Switch selection color.
Watch covariates and map as you click Apply button.
Covariates elements change order, but map order does not change.
If one changes, so should the other or neither should change.

@jmelott jmelott added bug Something isn't working show-stopper 2.21.3 labels Apr 20, 2023
@bmbroom
Copy link
Member

bmbroom commented Apr 21, 2023

I cannot reproduce. See attached before (green selection color) and after (purple selection color) screen shots.

AfterChangeSelectionColor
BeforeAnyChange

@jmelott
Copy link
Contributor Author

jmelott commented Apr 21, 2023

Just verifying since I can't tell from the screenshots, did you click apply? Asking because the change only happens on apply.

@jmelott
Copy link
Contributor Author

jmelott commented Apr 21, 2023

Testing in Chrome Version 112.0.5615.138 (Official Build) (64-bit) on Windows 10.0.19042
Before changing gaps color
image

After changing gaps color and clicking apply
image

@bmbroom
Copy link
Member

bmbroom commented Apr 21, 2023

Yes, I clicked Apply. I also tried changing Gaps color and clicking Apply. That had no effect either.

@bmbroom
Copy link
Member

bmbroom commented Apr 21, 2023

My original screen shots were with Chrome 112.0.5615.165 on Linux. I also tried Chrome on MacOS and Firefox on Linux. The screen shots from both those were the same as my screen shots above.

I notice both your screen shots differ from mine and from each other.

Bradley

@bmbroom
Copy link
Member

bmbroom commented Apr 21, 2023

Did you miss saying to change row/column ordering to Random in your instructions?

I notice that with that set, the covariate order changes but the map order doesn't when changing the map display.

@jmelott
Copy link
Contributor Author

jmelott commented Apr 21, 2023

It looks like I did. I guess I must thought the "Randomization of covariates" part covered it at the time, but I should have put it in the details too.

@jmelott
Copy link
Contributor Author

jmelott commented Apr 27, 2023

Still present in 2.23.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.21.3 bug Something isn't working show-stopper
Projects
None yet
Development

No branches or pull requests

2 participants