Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] revert old guessers removal #4752

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 20, 2024

Fixes #4751 #4753

TODO:

  • Add tests back
  • Add DeprecationWarning for old guessers and tables
  • Make sure tables is still exposed in the right place

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4752.org.readthedocs.build/en/4752/

@pep8speaks
Copy link

pep8speaks commented Oct 20, 2024

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 38:80: E501 line too long (80 > 79 characters)
Line 96:80: E501 line too long (115 > 79 characters)
Line 120:80: E501 line too long (89 > 79 characters)
Line 125:80: E501 line too long (81 > 79 characters)
Line 146:80: E501 line too long (108 > 79 characters)
Line 161:80: E501 line too long (84 > 79 characters)
Line 181:31: E261 at least two spaces before inline comment
Line 184:1: E302 expected 2 blank lines, found 1
Line 210:52: E261 at least two spaces before inline comment
Line 210:53: E262 inline comment should start with '# '
Line 314:38: E713 test for membership should be 'not in'
Line 437:16: E713 test for membership should be 'not in'

Line 93:1: W293 blank line contains whitespace
Line 103:21: W291 trailing whitespace
Line 149:1: E302 expected 2 blank lines, found 1
Line 151:80: E501 line too long (85 > 79 characters)
Line 157:1: E302 expected 2 blank lines, found 1
Line 164:1: E302 expected 2 blank lines, found 1

Comment last updated at 2024-10-20 09:48:56 UTC

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 84.09091% with 21 lines in your changes missing coverage. Please review.

Project coverage is 93.57%. Comparing base (101008b) to head (a4b884c).

Files with missing lines Patch % Lines
package/MDAnalysis/topology/guessers.py 83.59% 18 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4752      +/-   ##
===========================================
- Coverage    93.65%   93.57%   -0.08%     
===========================================
  Files          175      189      +14     
  Lines        21564    22762    +1198     
  Branches      3023     3051      +28     
===========================================
+ Hits         20195    21299    +1104     
- Misses         925     1016      +91     
- Partials       444      447       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert removal of MDAnalysis.topology.guessers in 2.x branch
2 participants