Update screenshots to current version #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. I would love to add those but I think I might have created additional work. The current release looks a lot different for macOS 11 upwards. I also might add the Demo.KDBX file to the repo to make contributions like yours easier. |
|
Ok, I could recreate them and the demo file would help a lot :) [I installed MacPass with brew, so I have to reinstall it again but that isn't a problem] |
|
@haudraufhaun do you still want to update the screenshots? I did finally push 0.8 so we now have an official version. Adding the new support for TOTP might also be an option. |
|
I can do it, maybe it takes a week or two because I'm busy with some exams right now 🤓. I'll close this pull request and do it on a totally new & fresh PR :) |
|
Awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #7
🍱 add new screenshots
I made new screenshots on the current MacPass version with macOS BigSur. For the full window screenshots, I sized the window to take 2/3 of my screen width and the full height (13inch MacBook Pro).
💄 update html and css for new screenshots
I just created a seperate directory for the screenshots and updated the paths to the images. I also added some missed attributes on the
imgelements (altandloading="lazy").I didn't got a fullsize searchscreen screenshot, because the search functionality wasn't working correctly on my machine. Maybe you could do one, or we still include the old
screenshot of the webpage with the new screenshots