Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperatingSystem implementation for Linux #167

Open
be4zad opened this issue May 9, 2024 · 2 comments
Open

OperatingSystem implementation for Linux #167

be4zad opened this issue May 9, 2024 · 2 comments
Labels
discussion Discuss something

Comments

@be4zad
Copy link

be4zad commented May 9, 2024

It seems operating system name is same with distro name.
Isn't it better to remove GeneralReadout::distribution() and replace it by GeneralReadout::os_name()?

@be4zad be4zad closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
@be4zad be4zad reopened this May 9, 2024
@be4zad
Copy link
Author

be4zad commented May 9, 2024

behzad@arch ~> hostnamectl
Operating System: Arch Linux 
…

@grtcdr
Copy link
Member

grtcdr commented May 10, 2024

I made that distinction in the API to accommodate the differences in semantics between operating systems. Operating systems built on Linux refer to themselves as distributions and the API reflects that, whether that was the right choice is debatable. I just don't think it's worth breaking backwards-compatibility for such a minor problem.

@grtcdr grtcdr added the discussion Discuss something label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discuss something
Development

No branches or pull requests

2 participants