Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor TypeCollector #366

Open
BenediktMehl opened this issue May 24, 2024 · 0 comments
Open

refactor TypeCollector #366

BenediktMehl opened this issue May 24, 2024 · 0 comments
Labels
tech

Comments

@BenediktMehl
Copy link
Collaborator

BenediktMehl commented May 24, 2024 •
edited
Loading

Refactor the TypesCollector.ts File and all the dependencies of this file. Especially the getTypes methods and all Calls and Sub-Calls of this method.
mylinhdao added a commit that referenced this issue May 27, 2024
@mylinhdao
test: add test for funciton getTypesFromFile() #366
52c2bd9
BenediktMehl pushed a commit that referenced this issue May 27, 2024
@benedikt-mehl-mw
refactor: getTypesFromFile method #366
d06b9cf
BenediktMehl pushed a commit that referenced this issue May 27, 2024
@benedikt-mehl-mw
refactor: type-query-strategy code cleanup #366
d1d8741
BenediktMehl pushed a commit that referenced this issue May 27, 2024
@benedikt-mehl-mw
test: skip tests that are failing now #366
2b1c19a 
We are sure that our refactoring is correct. We guess that the tests fail because the order of Types changes.
We will fix that in issue (#368).
@BenediktMehl BenediktMehl mentioned this issue May 27, 2024
Closed
4 tasks
mylinhdao added a commit that referenced this issue May 27, 2024
@mylinhdao
refactor: counting call-expression per type declaration #366
1a71783 
- remove types-query-strategy.test.ts temporary, because the structure of TypeInfo changed
- getUsage() now captures the usages per type declaration
BenediktMehl pushed a commit that referenced this issue May 28, 2024
@benedikt-mehl-mw
test: add more tests for types-query-strategy.ts #366
0f1b9ba
BenediktMehl pushed a commit that referenced this issue May 28, 2024
@benedikt-mehl-mw
fix: fix types-query-strategy for multiple namespaces for php #366
2e86789
BenediktMehl pushed a commit that referenced this issue May 28, 2024
@benedikt-mehl-mw
test: fix snapshot for php-coupling-metrics #366
2cb4667
BenediktMehl pushed a commit that referenced this issue May 28, 2024
@benedikt-mehl-mw
refactor: start refactoring of getUsages #366
85d124b
@BenediktMehl BenediktMehl mentioned this issue May 28, 2024
Merged
4 tasks
mylinhdao added a commit that referenced this issue Jun 3, 2024
@mylinhdao
test: add test for funciton getTypesFromFile() #366
89c0d89
mylinhdao pushed a commit that referenced this issue Jun 3, 2024
@benedikt-mehl-mw @mylinhdao
refactor: getTypesFromFile method #366
5294ea6
mylinhdao pushed a commit that referenced this issue Jun 3, 2024
@benedikt-mehl-mw @mylinhdao
refactor: type-query-strategy code cleanup #366
c1a0dce
mylinhdao pushed a commit that referenced this issue Jun 3, 2024
@benedikt-mehl-mw @mylinhdao
test: skip tests that are failing now #366
6ad4b3d 
We are sure that our refactoring is correct. We guess that the tests fail because the order of Types changes.
We will fix that in issue (#368).
mylinhdao pushed a commit that referenced this issue Jun 3, 2024
@benedikt-mehl-mw @mylinhdao
test: add more tests for types-query-strategy.ts #366
d4cadf2
mylinhdao pushed a commit that referenced this issue Jun 3, 2024
@benedikt-mehl-mw @mylinhdao
fix: fix types-query-strategy for multiple namespaces for php #366
f5a37ab
mylinhdao pushed a commit that referenced this issue Jun 3, 2024
@benedikt-mehl-mw @mylinhdao
test: fix snapshot for php-coupling-metrics #366
eedba9d
mylinhdao pushed a commit that referenced this issue Jun 3, 2024
@benedikt-mehl-mw @mylinhdao
refactor: start refactoring of getUsages #366
db3892b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/366/type declaration MaibornWolff/metric-gardener
1 participant
@BenediktMehl