Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add indeterminate checkbox for checkbox group #199

Open
m-m-mic opened this issue Jul 13, 2023 · 2 comments
Open

[Feat] Add indeterminate checkbox for checkbox group #199

m-m-mic opened this issue Jul 13, 2023 · 2 comments
Labels
enhancement New feature or request UI Review Feedback

Comments

@m-m-mic
Copy link
Contributor

m-m-mic commented Jul 13, 2023

When we have a parent checkbox with children, the parent checkbox should display as indeterminate if not all children have the same state.

Example from IntelliJ:

image
@m-m-mic m-m-mic self-assigned this Jul 13, 2023
@m-m-mic m-m-mic added enhancement New feature or request UI Review Feedback labels Jul 13, 2023
m-m-mic added a commit that referenced this issue Jul 18, 2023
@m-m-mic
Merge branch 'main' into #199-checkbox-group
f83910c
@m-m-mic
Copy link
Contributor Author

m-m-mic commented Jul 21, 2023

Implemented on branch, currently there's a bug when all checkboxes are selected and you deselect two and then click the parent checkbox again, one of the deselected checkboxes doesn't change appearance (but its value still gets properly added to the values array).

m-m-mic added a commit that referenced this issue Jul 24, 2023
@m-m-mic
Merge branch '#198-controls-improvements' into #199-checkbox-group
765d934
@m-m-mic
Copy link
Contributor Author

m-m-mic commented Jul 24, 2023

Implemented on branch, currently there's a bug when all checkboxes are selected and you deselect two and then click the parent checkbox again, one of the deselected checkboxes doesn't change appearance (but its value still gets properly added to the values array).

Resolved issue, branch should now be ready for review.

@m-m-mic m-m-mic removed their assignment Jul 26, 2023
Fuasmattn added a commit that referenced this issue Jul 26, 2023
@Fuasmattn
Merge pull request #204 from MaibornWolff/#199-checkbox-group
5740483 
#199 checkbox group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request UI Review Feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m-m-mic