Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmtilesRules fails with missing protomapsL global variable #1011

Closed
prushforth opened this issue Nov 8, 2024 · 0 comments · Fixed by #1015
Closed

pmtilesRules fails with missing protomapsL global variable #1011

prushforth opened this issue Nov 8, 2024 · 0 comments · Fixed by #1015
Labels

Comments

@prushforth
Copy link
Member

This bug was introduced by the transition to full es modules (I think).

The solution is to manually (conditionally) create the protomapsL global before importing the pmtilesRules for a layer, which currently sometimes fails, because for example simply designating a theme does not avail itself of the protomapsL variable symbols, but creating custom symbolizers does indeed rely on those exports.

Needs a test, which means it needs some spearfish mvt files save to test/data to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant