Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it DRY #4

Open
JSteunou opened this issue Jan 3, 2015 · 0 comments
Open

Make it DRY #4

JSteunou opened this issue Jan 3, 2015 · 0 comments

Comments

@JSteunou
Copy link
Member

JSteunou commented Jan 3, 2015

Big issue with show and add methods. They use a lot of similar code. This comes from the Marionette.Region.prototype.show which is quite big and not cut in pieces.

I think the _shouldDestroyView and the _shouldShowView parts could be extracted and show could use add.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JSteunou