Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hiding the popover #30

Open
Saheb opened this issue Apr 7, 2018 · 2 comments
Open

Support for hiding the popover #30

Saheb opened this issue Apr 7, 2018 · 2 comments

Comments

@Saheb
Copy link

Saheb commented Apr 7, 2018

Once the action is performed, it should be possible to call hide/close/killPopover. At the moment, it's only possible to destroy.

@Saheb
Copy link
Author

Saheb commented Apr 7, 2018

I just moved killPopover into the return statement, that seemed to expose that function and works as expected. Not sure if that's the right way.

But, I think that should be the default behavior across sharers, what do you think about that?

@jpoles1
Copy link

jpoles1 commented Aug 13, 2018

I also think this would be a helpful feature! Can you explain a bit more how you got it done @Saheb?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants